Skip to content

Commit

Permalink
chore: Update logic in migration fcea065655
Browse files Browse the repository at this point in the history
  • Loading branch information
john-bodley committed May 10, 2024
1 parent f29e1e4 commit 91ceda7
Show file tree
Hide file tree
Showing 3 changed files with 53 additions and 2 deletions.
1 change: 1 addition & 0 deletions UPDATING.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ assists people when migrating to a new version.
### Potential Downtime

- [27392](https://github.com/apache/superset/pull/27392): Adds an index to `query.sql_editor_id` to improve performance. This may cause downtime on large deployments.
- [28422](https://github.com/apache/superset/pull/28422): Potentially augments the `query.executed_sql` and `query.select_sql` columns for MySQL from `MEDIUMTEXT` to `LONGTEXT`. Potential downtime may be required for large deployments which previously ran [27119](https://github.com/apache/superset/pull/27119).

## 4.0.0

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@
"dashboards.css",
"keyvalue.value",
"query.extra_json",
"query.executed_sql",
"query.select_sql",
"report_execution_log.value_row_json",
"report_recipient.recipient_config_json",
"report_schedule.sql",
Expand Down
52 changes: 52 additions & 0 deletions superset/migrations/versions/2024-05-09_19-19_f7b6750b67e8_.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
"""change_mediumtext_to_longtext
Revision ID: f7b6750b67e8
Revises: 4081be5b6b74
Create Date: 2024-05-09 19:19:46.630140
"""

# revision identifiers, used by Alembic.
revision = "f7b6750b67e8"
down_revision = "4081be5b6b74"

from alembic import op # noqa: E402
from sqlalchemy.dialects.mysql import LONGTEXT, MEDIUMTEXT # noqa: E402
from sqlalchemy.dialects.mysql.base import MySQLDialect # noqa: E402
from sqlalchemy.engine.reflection import Inspector # noqa: E402


def upgrade():
bind = op.get_bind()

if isinstance(bind.dialect, MySQLDialect):
for column in Inspector.from_engine(bind).get_columns("query"):
for name in ["executed_sql", "select_sql"]:
if column["name"] == name and isinstance(column["type"], MEDIUMTEXT):
with op.batch_alter_table("query") as batch_op:
batch_op.alter_column(
name,
existing_type=MEDIUMTEXT,
type_=LONGTEXT,
existing_nullable=True,
)


def downgrade():
pass

0 comments on commit 91ceda7

Please sign in to comment.