[fix] allow force refresh for No Results chart

apache · Mar 30, 2020 · b64270b · b64270b
1 parent cfa7868
commit b64270b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/superset-frontend/src/chart/chartReducer.js b/superset-frontend/src/chart/chartReducer.js
@@ -49,6 +49,7 @@ export default function chartReducer(charts = {}, action) {
         chartStatus: 'success',
         queryResponse: action.queryResponse,
         chartAlert: null,
+        chartUpdateEndTime: now(),
       };
     },
     [actions.CHART_UPDATE_STARTED](state) {

diff --git a/superset-frontend/src/dashboard/components/SliceHeaderControls.jsx b/superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
@@ -133,7 +133,10 @@ class SliceHeaderControls extends React.PureComponent {
         </Dropdown.Toggle>
 
         <Dropdown.Menu>
-          <MenuItem onClick={this.refreshChart} disabled={!updatedDttm}>
+          <MenuItem
+            onClick={this.refreshChart}
+            disabled={this.props.chartStatus === 'loading'}
+          >
             {t('Force refresh')}
             <div className="refresh-tooltip">{refreshTooltip}</div>
           </MenuItem>