chore: refactor ChartHolder to typescript + tests (#20910)

apache · Sep 5, 2022 · b71182f · b71182f
1 parent d994bab
commit b71182f
Show file tree

Hide file tree

Showing 9 changed files with 1,005 additions and 574 deletions.
diff --git a/superset-frontend/src/dashboard/components/AnchorLink/index.tsx b/superset-frontend/src/dashboard/components/AnchorLink/index.tsx
@@ -26,9 +26,10 @@ import getLocationHash from 'src/dashboard/util/getLocationHash';
 
 export type AnchorLinkProps = {
  id: string;
+ dashboardId?: number;
  scrollIntoView?: boolean;
  showShortLinkButton?: boolean;
-} & Pick<URLShortLinkButtonProps, 'dashboardId' | 'placement'>;
+} & Pick<URLShortLinkButtonProps, 'placement'>;
 
 export default function AnchorLink({
  id,

diff --git a/superset-frontend/src/dashboard/components/dnd/DragDroppable.jsx b/superset-frontend/src/dashboard/components/dnd/DragDroppable.jsx
@@ -46,12 +46,12 @@ const propTypes = {
  useEmptyDragPreview: PropTypes.bool,
 
  // from react-dnd
- isDragging: PropTypes.bool.isRequired,
- isDraggingOver: PropTypes.bool.isRequired,
- isDraggingOverShallow: PropTypes.bool.isRequired,
- droppableRef: PropTypes.func.isRequired,
- dragSourceRef: PropTypes.func.isRequired,
- dragPreviewRef: PropTypes.func.isRequired,
+ isDragging: PropTypes.bool,
+ isDraggingOver: PropTypes.bool,
+ isDraggingOverShallow: PropTypes.bool,
+ droppableRef: PropTypes.func,
+ dragSourceRef: PropTypes.func,
+ dragPreviewRef: PropTypes.func,
 };
 
 const defaultProps = {
@@ -63,6 +63,12 @@ const defaultProps = {
  onDrop() {},
  orientation: 'row',
  useEmptyDragPreview: false,
+ isDragging: false,
+ isDraggingOver: false,
+ isDraggingOverShallow: false,
+ droppableRef() {},
+ dragSourceRef() {},
+ dragPreviewRef() {},
 };
 
 // export unwrapped component for testing
@@ -95,7 +101,7 @@ export class UnwrappedDragDroppable extends React.PureComponent {
  } else {
  this.props.dragPreviewRef(ref);
  }
- this.props.droppableRef(ref);
+ this.props.droppableRef?.(ref);
  }
 
  render() {