Skip to content

Commit

Permalink
fix(ChartTable): replace root React.Fragment with ErrorBoundary
Browse files Browse the repository at this point in the history
  • Loading branch information
maxamante committed Jan 4, 2021
1 parent 7cc0de1 commit c556c4f
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions superset-frontend/src/views/CRUD/welcome/ChartTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import { User } from 'src/types/bootstrapTypes';
import Icon from 'src/components/Icon';
import ChartCard from 'src/views/CRUD/chart/ChartCard';
import Chart from 'src/types/Chart';
import ErrorBoundary from 'src/components/ErrorBoundary'
import SubMenu from 'src/components/Menu/SubMenu';
import EmptyState from './EmptyState';
import { CardContainer, IconContainer } from '../utils';
Expand Down Expand Up @@ -114,7 +115,7 @@ function ChartTable({
};

return (
<>
<ErrorBoundary>
{sliceCurrentlyEditing && (
<PropertiesModal
onHide={closeChartEditModal}
Expand Down Expand Up @@ -188,7 +189,7 @@ function ChartTable({
) : (
<EmptyState tableName="CHARTS" tab={chartFilter} />
)}
</>
</ErrorBoundary>
);
}

Expand Down

0 comments on commit c556c4f

Please sign in to comment.