fix(explore): JS error for creating new metrics from columns

apache · Aug 26, 2021 · d121296 · d121296
1 parent ee2eccd
commit d121296
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx
@@ -186,9 +186,7 @@ export const DndMetricSelect = (props: any) => {
 
   const onNewMetric = useCallback(
     (newMetric: Metric) => {
-      const newValue = props.multi
-        ? [...value, newMetric.metric_name]
-        : [newMetric.metric_name];
+      const newValue = props.multi ? [...value, newMetric] : [newMetric];
       setValue(newValue);
       handleChange(newValue);
     },