Reenable visualization tests

superset-frontend/cypress-base/cypress/integration/explore/visualizations/filter_box.js → superset-frontend/cypress-base/cypress/integration/explore/filter_box.test.js

@@ -16,28 +16,27 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { FORM_DATA_DEFAULTS } from './shared.helper';
+import { FORM_DATA_DEFAULTS } from './visualizations/shared.helper';
 
-export default () =>
-  describe('FilterBox', () => {
-    const VIZ_DEFAULTS = { ...FORM_DATA_DEFAULTS, viz_type: 'filter_box' };
+describe('Edit FilterBox Chart', () => {
+  const VIZ_DEFAULTS = { ...FORM_DATA_DEFAULTS, viz_type: 'filter_box' };
 
-    function verify(formData) {
-      cy.visitChartByParams(JSON.stringify(formData));
-      cy.verifySliceSuccess({ waitAlias: '@getJson' });
-    }
+  function verify(formData) {
+    cy.visitChartByParams(JSON.stringify(formData));
+    cy.verifySliceSuccess({ waitAlias: '@getJson' });
+  }
 
-    beforeEach(() => {
-      cy.server();
-      cy.login();
-      cy.route('POST', '/superset/explore_json/**').as('getJson');
-    });
+  beforeEach(() => {
+    cy.server();
+    cy.login();
+    cy.route('POST', '/superset/explore_json/**').as('getJson');
+  });
 
-    it('should work with default date filter', () => {
-      verify(VIZ_DEFAULTS);
-      // Filter box should default to having a date filter with no filter selected
-      cy.get('div.filter_box').within(() => {
-        cy.get('span').contains('No filter');
-      });
+  it('should work with default date filter', () => {
+    verify(VIZ_DEFAULTS);
+    // Filter box should default to having a date filter with no filter selected
+    cy.get('div.filter_box').within(() => {
+      cy.get('span').contains('No filter');
     });
   });
+});

superset-frontend/cypress-base/cypress/integration/explore/visualizations/area.test.js

@@ -0,0 +1,114 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import readResponseBlob from '../../../utils/readResponseBlob';
+
+describe('Visualization > Area', () => {
+  const AREA_FORM_DATA = {
+    datasource: '2__table',
+    viz_type: 'area',
+    slice_id: 48,
+    granularity_sqla: 'year',
+    time_grain_sqla: 'P1D',
+    time_range: '1960-01-01 : now',
+    metrics: ['sum__SP_POP_TOTL'],
+    adhoc_filters: [],
+    groupby: [],
+    limit: '25',
+    order_desc: true,
+    contribution: false,
+    row_limit: 50000,
+    show_brush: 'auto',
+    show_legend: true,
+    line_interpolation: 'linear',
+    stacked_style: 'stack',
+    color_scheme: 'bnbColors',
+    rich_tooltip: true,
+    show_controls: false,
+    x_axis_label: '',
+    bottom_margin: 'auto',
+    x_ticks_layout: 'auto',
+    x_axis_format: 'smart_date',
+    x_axis_showminmax: false,
+    y_axis_format: '.3s',
+    y_log_scale: false,
+    rolling_type: 'None',
+    comparison_type: 'values',
+    annotation_layers: [],
+  };
+
+  function verify(formData) {
+    cy.visitChartByParams(JSON.stringify(formData));
+    cy.verifySliceSuccess({ waitAlias: '@getJson', chartSelector: 'svg' });
+  }
+
+  beforeEach(() => {
+    cy.server();
+    cy.login();
+    cy.route('POST', '/superset/explore_json/**').as('getJson');
+  });
+
+  it('should work without groupby', () => {
+    verify(AREA_FORM_DATA);
+    cy.get('.nv-area').should('have.length', 1);
+  });
+
+  it('should work with group by', () => {
+    verify({
+      ...AREA_FORM_DATA,
+      groupby: ['region'],
+    });
+
+    cy.get('.nv-area').should('have.length', 7);
+  });
+
+  it('should work with groupby and filter', () => {
+    cy.visitChartByParams(
+      JSON.stringify({
+        ...AREA_FORM_DATA,
+        groupby: ['region'],
+        adhoc_filters: [
+          {
+            expressionType: 'SIMPLE',
+            subject: 'region',
+            operator: 'in',
+            comparator: ['South Asia', 'North America'],
+            clause: 'WHERE',
+            sqlExpression: null,
+            filterOptionName: 'filter_txje2ikiv6_wxmn0qwd1xo',
+          },
+        ],
+      }),
+    );
+
+    cy.wait('@getJson').then(async xhr => {
+      cy.verifyResponseCodes(xhr);
+
+      const responseBody = await readResponseBlob(xhr.response.body);
+
+      // Make sure data is sorted correctly
+      const firstRow = responseBody.data[0].values;
+      const secondRow = responseBody.data[1].values;
+      expect(firstRow[firstRow.length - 1].y).to.be.greaterThan(
+        secondRow[secondRow.length - 1].y,
+      );
+      cy.verifySliceContainer('svg');
+    });
+    cy.get('.nv-area').should('have.length', 2);
+  });
+});