fix(sql-editor): Fix run stop button color to improve usability (#23892)

Co-authored-by: aadhikari <aadhikari@apple.com>
apache · May 3, 2023 · d4b9c18 · d4b9c18
1 parent 3528f41
commit d4b9c18
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx b/superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx
@@ -146,7 +146,9 @@ const RunQueryActionButton = ({
  ),
  trigger: 'click',
  }
- : { buttonStyle: 'primary' })}
+ : {
+ buttonStyle: shouldShowStopBtn ? 'warning' : 'primary',
+ })}
  >
  {buildText(shouldShowStopBtn, selectedText)}
  </ButtonComponent>

diff --git a/superset-frontend/src/explore/components/RunQueryButton/index.tsx b/superset-frontend/src/explore/components/RunQueryButton/index.tsx
@@ -42,7 +42,7 @@ export const RunQueryButton = ({
 }: RunQueryButtonProps) =>
  loading ? (
  <Button onClick={onStop} buttonStyle="warning" disabled={!canStopQuery}>
- <i className="fa fa-stop-circle-o" /> {t('Stop')}
+ <i className="fa fa-stop" /> {t('Stop')}
  </Button>
  ) : (
  <Button