Skip to content

Commit

Permalink
test: Menu component tests (#13302)
Browse files Browse the repository at this point in the history
* Add tests for the Menu component

* Clean up and add  NewMenu - SubMenu tests

* Remove obsolete SubMenu test

* Add LanguagePicker tests
  • Loading branch information
geido authored Feb 25, 2021
1 parent 45cca3a commit f3f37b0
Show file tree
Hide file tree
Showing 9 changed files with 487 additions and 321 deletions.
212 changes: 0 additions & 212 deletions superset-frontend/spec/javascripts/components/Menu_spec.jsx

This file was deleted.

108 changes: 0 additions & 108 deletions superset-frontend/spec/javascripts/components/SubMenu_spec.jsx

This file was deleted.

54 changes: 54 additions & 0 deletions superset-frontend/src/components/Menu/LanguagePicker.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import React from 'react';
import { render, screen } from 'spec/helpers/testing-library';
import LanguagePicker from './LanguagePicker';

const mockedProps = {
locale: 'en',
languages: {
en: {
flag: 'us',
name: 'English',
url: '/lang/en',
},
it: {
flag: 'it',
name: 'Italian',
url: '/lang/it',
},
},
};

test('should render', () => {
const { container } = render(<LanguagePicker {...mockedProps} />);
expect(container).toBeInTheDocument();
});

test('should render the button', () => {
render(<LanguagePicker {...mockedProps} />);
const button = screen.getByRole('button');
expect(button).toHaveAttribute('href', '#');
});

test('should render the menuitem', () => {
render(<LanguagePicker {...mockedProps} />);
const menuitem = screen.getByRole('menuitem');
expect(menuitem).toHaveTextContent('Italian');
});
1 change: 1 addition & 0 deletions superset-frontend/src/components/Menu/LanguagePicker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ export default function LanguagePicker({
<i className={`flag ${languages[locale].flag}`} />
</span>
}
data-test="language-picker"
>
<Menu
onSelect={({ key }) => {
Expand Down
Loading

0 comments on commit f3f37b0

Please sign in to comment.