Skip to content

Commit

Permalink
chore(Embedded): Avoid creating a filter key for guest users (#26312)
Browse files Browse the repository at this point in the history
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
  • Loading branch information
Vitor-Avila and michael-s-molina authored Dec 27, 2023
1 parent 5f5a656 commit fe9fbad
Showing 1 changed file with 9 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ import { useTabId } from 'src/hooks/useTabId';
import { logEvent } from 'src/logger/actions';
import { LOG_ACTIONS_CHANGE_DASHBOARD_FILTER } from 'src/logger/LogUtils';
import { FilterBarOrientation, RootState } from 'src/dashboard/types';
import { UserWithPermissionsAndRoles } from 'src/types/bootstrapTypes';
import { checkIsApplyDisabled } from './utils';
import { FiltersBarProps } from './types';
import {
Expand Down Expand Up @@ -149,6 +150,10 @@ const FilterBar: React.FC<FiltersBarProps> = ({
const canEdit = useSelector<RootState, boolean>(
({ dashboardInfo }) => dashboardInfo.dash_edit_perm,
);
const user: UserWithPermissionsAndRoles = useSelector<
RootState,
UserWithPermissionsAndRoles
>(state => state.user);

const [filtersInScope] = useSelectFiltersInScope(nativeFilterValues);

Expand Down Expand Up @@ -220,7 +225,10 @@ const FilterBar: React.FC<FiltersBarProps> = ({
}, [dataMaskAppliedText, setDataMaskSelected]);

useEffect(() => {
publishDataMask(history, dashboardId, updateKey, dataMaskApplied, tabId);
// embedded users can't persist filter combinations
if (user?.userId) {
publishDataMask(history, dashboardId, updateKey, dataMaskApplied, tabId);
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [dashboardId, dataMaskAppliedText, history, updateKey, tabId]);

Expand Down

0 comments on commit fe9fbad

Please sign in to comment.