Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more dashboard semantics around how filters affect slices #1057

Closed
mistercrunch opened this issue Sep 1, 2016 · 1 comment
Closed
Assignees

Comments

@mistercrunch
Copy link
Member

mistercrunch commented Sep 1, 2016

Currently:

  • Widgets can emit filters
  • The "dashboard controller" applies this filter by refreshing slices with an extra filter parameter
  • Slices (in the context of a dashboard) can be made immune to filtering by editing the json configuration behind the dashboard (no ui controls are exposed to set this up)

Needed:

  • Allow specifying which slices are immune to which fields.

Currently, the json_metadata for the dashboard has a filter_immune_slices key, which receives an array of slice ids. This should still be supported.

On top of that we need a new key filter_immune_slice_fields that is an object where the key is a slice_id, and the value an array of fields that it disregards. Or something equivalent.

@vera-liu
Copy link
Contributor

Sorry didn't started looking into this until today, already done in: #1179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants