Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[filtering] define combo of slice/fields unafected by filtering #1179

Merged
merged 4 commits into from
Sep 23, 2016
Merged

[filtering] define combo of slice/fields unafected by filtering #1179

merged 4 commits into from
Sep 23, 2016

Conversation

mistercrunch
Copy link
Member

No description provided.

ascott
ascott reviewed Sep 22, 2016
View reviewed changes
caravel/assets/javascripts/modules/caravel.js
const flts =
newParams.extraFilters === false ? '' :
encodeURIComponent(JSON.stringify(dashboard.filters));
let flts;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could simplify to

let flts = '';
if (newParams.extraFilters) {
  flts = dashboard.effectiveExtraFilters(sliceId);
  flts = encodeURIComponent(JSON.stringify(flts));
}

@mistercrunch mistercrunch merged commit aed473d into apache:master Sep 23, 2016
@mistercrunch mistercrunch deleted the filter_slice_fields branch September 23, 2016 03:12
@vera-liu vera-liu mentioned this pull request Sep 29, 2016
Closed
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@suddjian @pkdotson
@rusackas @michael-s-molina @zhaoyongjie
chore: Add new plugin metadata (apache#1179)
6547122 
* chore: add new plugin metadata

* inital commit

* capitalization

* Update plugins/legacy-plugin-chart-calendar/src/index.js

* Update plugins/legacy-preset-chart-big-number/src/BigNumber/index.ts

* Update plugins/legacy-plugin-chart-histogram/src/index.js

* edits

* Update plugins/legacy-preset-chart-nvd3/src/Bar/index.js

* fix: single quote

* Update plugins/legacy-preset-chart-big-number/src/BigNumber/index.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update plugins/legacy-preset-chart-nvd3/src/Bullet/index.js

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@suddjian @pkdotson
@rusackas @michael-s-molina @zhaoyongjie
chore: Add new plugin metadata (apache#1179)
6c41ef3 
* chore: add new plugin metadata

* inital commit

* capitalization

* Update plugins/legacy-plugin-chart-calendar/src/index.js

* Update plugins/legacy-preset-chart-big-number/src/BigNumber/index.ts

* Update plugins/legacy-plugin-chart-histogram/src/index.js

* edits

* Update plugins/legacy-preset-chart-nvd3/src/Bar/index.js

* fix: single quote

* Update plugins/legacy-preset-chart-big-number/src/BigNumber/index.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update plugins/legacy-preset-chart-nvd3/src/Bullet/index.js

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@suddjian @pkdotson
@rusackas @michael-s-molina @zhaoyongjie
chore: Add new plugin metadata (apache#1179)
ee1bd7c 
* chore: add new plugin metadata

* inital commit

* capitalization

* Update plugins/legacy-plugin-chart-calendar/src/index.js

* Update plugins/legacy-preset-chart-big-number/src/BigNumber/index.ts

* Update plugins/legacy-plugin-chart-histogram/src/index.js

* edits

* Update plugins/legacy-preset-chart-nvd3/src/Bar/index.js

* fix: single quote

* Update plugins/legacy-preset-chart-big-number/src/BigNumber/index.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update plugins/legacy-preset-chart-nvd3/src/Bullet/index.js

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@suddjian @pkdotson
@rusackas @michael-s-molina @zhaoyongjie
chore: Add new plugin metadata (apache#1179)
1e6c0d2 
* chore: add new plugin metadata

* inital commit

* capitalization

* Update plugins/legacy-plugin-chart-calendar/src/index.js

* Update plugins/legacy-preset-chart-big-number/src/BigNumber/index.ts

* Update plugins/legacy-plugin-chart-histogram/src/index.js

* edits

* Update plugins/legacy-preset-chart-nvd3/src/Bar/index.js

* fix: single quote

* Update plugins/legacy-preset-chart-big-number/src/BigNumber/index.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update plugins/legacy-preset-chart-nvd3/src/Bullet/index.js

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
This was referenced Feb 1, 2022
Open
Open
Closed
Open
@snyk-bot snyk-bot mentioned this pull request Feb 21, 2022
Closed
@terrorizer1980 terrorizer1980 mentioned this pull request Jun 22, 2022
Closed
This was referenced Sep 27, 2022
Open
Open
This was referenced Oct 6, 2022
Open
Open
Open
Open
@terrorizer1980 terrorizer1980 mentioned this pull request May 24, 2023
Closed
@lili2311 lili2311 mentioned this pull request Jul 4, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Jul 4, 2023
Closed
@mariasnyk mariasnyk mentioned this pull request Jul 4, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Jul 5, 2023
Closed
@xiezhongfu xiezhongfu mentioned this pull request Jul 5, 2023
Open
@xiezhongfu xiezhongfu mentioned this pull request Nov 26, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Nov 29, 2023
Closed
@lili2311 lili2311 mentioned this pull request Nov 29, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Nov 30, 2023
Closed
@xiezhongfu xiezhongfu mentioned this pull request Dec 19, 2023
Open
This was referenced Dec 19, 2023
Closed
Closed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024
This was referenced Apr 29, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascott ascott ascott left review comments

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistercrunch @ascott