Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seek help menu icon cannot be displayed #11339

Closed
xuningyang opened this issue Oct 20, 2020 · 3 comments
Closed

seek help menu icon cannot be displayed #11339

xuningyang opened this issue Oct 20, 2020 · 3 comments
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed !deprecated-label:bug Deprecated label - Use #bug instead

Comments

@xuningyang
Copy link

Expected results

企业微信截图_f8e0a494-c899-4b3d-addc-d41a2f6433c6

Actual results

企业微信截图_2b9253c0-53c6-4e5e-9af0-49c3da81e84b

Environment

python: python 3.6
npm: 6.14.6
Superset 0.999.0dev
node:v12.18.3

Description

superset back-end starts normally, and the front-end compilation has no errors.
After entering superset, the public menu bar cannot display the icon

@xuningyang xuningyang added the #bug:cosmetic Cosmetic/layout/design tweak needed label Oct 20, 2020
@issue-label-bot issue-label-bot bot added the !deprecated-label:bug Deprecated label - Use #bug instead label Oct 20, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.97. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@zhaoyongjie
Copy link
Member

zhaoyongjie commented Oct 21, 2020

hi @xuningyang . I checked the icon conf in FAB, like this
https://github.com/apache/incubator-superset/blob/cae54ac00e154ddfb0699e0dde7233b5942c5e70/superset/app.py#L217-L225

so I guess some font style overwrite the existing FAB icon.

In Chinese:
你好. 我已经检查过FAB的设置, 看起来这些icon都还在. 我猜可能是一些前端文件覆盖了原有样式

@junlincc
Copy link
Member

Hi @xuningyang and @zhaoyongjie We removed these nav bar icons while we reorganized the navigation by design, to get closer to the proposed design in SIP-34 for keeping the cleanness and consistency. if you would like to make any contributions on improving the UI, SIP-34 can be a good guideline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed !deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

No branches or pull requests

3 participants