Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navbar missing icon #11358

Closed
wants to merge 1 commit into from
Closed

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

fix navbar missing icon #11339

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Oct 21, 2020

Codecov Report

Merging #11358 into master will decrease coverage by 6.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11358      +/-   ##
==========================================
- Coverage   65.78%   58.96%   -6.82%     
==========================================
  Files         838      800      -38     
  Lines       39841    38515    -1326     
  Branches     3655     3443     -212     
==========================================
- Hits        26208    22711    -3497     
- Misses      13532    15634    +2102     
- Partials      101      170      +69     
Flag Coverage Δ
#cypress 55.97% <ø> (-0.05%) ⬇️
#javascript ?
#python 60.59% <ø> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Menu/Menu.tsx 92.95% <ø> (-1.98%) ⬇️
...perset-frontend/src/components/Menu/MenuObject.tsx 90.00% <ø> (+3.33%) ⬆️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/components/Menu/LanguagePicker.tsx 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...uperset-frontend/src/utils/getClientErrorObject.ts 0.00% <0.00%> (-89.19%) ⬇️
.../src/dashboard/components/FilterIndicatorGroup.jsx 11.76% <0.00%> (-88.24%) ⬇️
...c/explore/components/controls/withVerification.jsx 9.09% <0.00%> (-87.88%) ⬇️
... and 276 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cae54ac...0c95999. Read the comment docs.

@zhaoyongjie zhaoyongjie deleted the fix_icon_lost branch January 16, 2021 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants