Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved Queries Page Doesn't Load After User Tries to Save a Blank Query #11647

Closed
2 of 3 tasks
yousoph opened this issue Nov 10, 2020 · 1 comment · Fixed by #11649
Closed
2 of 3 tasks

Saved Queries Page Doesn't Load After User Tries to Save a Blank Query #11647

yousoph opened this issue Nov 10, 2020 · 1 comment · Fixed by #11649
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@yousoph
Copy link
Member

yousoph commented Nov 10, 2020

When a user tries to save a blank query, the query doesn't get saved and the Save Queries page fails to load and shows an error.

Expected results

In SQL Lab, the user should either not be able to save a blank query or they should be able to save it properly.

Actual results

  • When visiting the Saved Queries page, the page shows an error
  • When returning to SQL Lab or refreshing the page, the query that the user tried to save is not properly saved

Screenshots

Saved Queries:
image

How to reproduce the bug

  1. Go to SQL Lab
  2. Make sure there is no text in the query
  3. Click the "Save" button and enter a title

Environment

  • superset version: master

Checklist

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@yousoph yousoph added the !deprecated-label:bug Deprecated label - Use #bug instead label Nov 10, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.98. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant