Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(saved-query): handle case where sql_tables in undefined #11649

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

nytai
Copy link
Member

@nytai nytai commented Nov 10, 2020

SUMMARY

Handles case where sql_tables is undefined in the api response. see linked issue for details.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

manually tested following steps listed in the linked issue

ADDITIONAL INFORMATION

@codecov-io
Copy link

codecov-io commented Nov 10, 2020

Codecov Report

Merging #11649 (65004fb) into master (091432e) will decrease coverage by 4.32%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11649      +/-   ##
==========================================
- Coverage   66.59%   62.26%   -4.33%     
==========================================
  Files         876      873       -3     
  Lines       42146    42303     +157     
  Branches     3943     3971      +28     
==========================================
- Hits        28066    26342    -1724     
- Misses      13977    15781    +1804     
- Partials      103      180      +77     
Flag Coverage Δ
cypress ?
javascript 62.84% <0.00%> (+0.27%) ⬆️
python 61.92% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/views/CRUD/data/savedquery/SavedQueryList.tsx 61.36% <0.00%> (-0.47%) ⬇️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupFormatters.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
... and 199 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 091432e...65004fb. Read the comment docs.

@nytai nytai merged commit 329e728 into apache:master Nov 11, 2020
@nytai nytai deleted the tai/fix-saved-query branch November 11, 2020 01:26
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saved Queries Page Doesn't Load After User Tries to Save a Blank Query
6 participants