Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Explore] Users should be able to clear custom label for adhoc metric #12380

Closed
ktmud opened this issue Jan 9, 2021 · 1 comment · Fixed by #12382
Closed

[Explore] Users should be able to clear custom label for adhoc metric #12380

ktmud opened this issue Jan 9, 2021 · 1 comment · Fixed by #12382
Assignees
@villebro
Labels
assigned:preset Assigned to the Preset team explore:control Related to the controls panel of Explore P2 Priority item - High

Comments

@ktmud
Copy link
Member

ktmud commented Jan 9, 2021

Screenshots

How to reproduce the bug

  1. Add an adhoc metric, give it a custom label
  2. Try clear the custom label
  3. The label should revert to the default auto-generated label, instead of reverting to the already-cleared custom label.

Environment

Latest master.

This is in table chart's percent metrics.
@ktmud ktmud added P1 Priority item - Major explore:control Related to the controls panel of Explore #bug Bug report labels Jan 9, 2021
@junlincc junlincc added P2 Priority item - High and removed #bug Bug report P1 Priority item - Major labels Jan 9, 2021
@villebro villebro self-assigned this Jan 9, 2021
@villebro villebro mentioned this issue Jan 9, 2021
Merged
6 tasks
@junlincc junlincc added the assigned:preset Assigned to the Preset team label Jan 9, 2021
@junlincc
Copy link
Member

junlincc commented Jan 9, 2021

Confirming this issue is resolved in latest master 01/09/2021 @ 10:58am (UTC)

Remaining related issues will be addressed by rc2
[Explore] Custom labels for new adhoc metric should be empty
[Explore] Saved metrics label overrides not working
cc @graceguo-supercat @ktmud @zuzana-vej @mistercrunch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@villebro villebro

Labels
assigned:preset Assigned to the Preset team explore:control Related to the controls panel of Explore P2 Priority item - High
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(explore): clear custom label if removed preset-io/superset
3 participants
@ktmud @villebro @junlincc