fix(explore): clear custom label if removed

[villebro]

SUMMARY

When clearing the custom label, it should be reverted to the default label.

AFTER SCREENSHOTS OR ANIMATED GIF

ADDITIONAL INFORMATION

• Has associated issue: closes [Explore] Users should be able to clear custom label for adhoc metric #12380
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[ktmud]

LGTM. Thanks for the quick fix!

[villebro]

FYI @ktmud this will probably need some further improvement as the current UX is slightly confusing (I can continue next week), but for now this is probably an ok quick fix.

[junlincc]

LGTM! thanks for the fix! agreed current designed solution is not ideal. we should invest some design effort in Explore popovers

instead of showing my metrics, it should display the auto generated label

[codecov-io]

Codecov Report

Merging #12382 (e7e1067) into master (4175152) will decrease coverage by 15.82%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #12382       +/-   ##
===========================================
- Coverage   66.76%   50.93%   -15.83%     
===========================================
  Files        1014      473      -541     
  Lines       49508    16862    -32646     
  Branches     5063     4325      -738     
===========================================
- Hits        33052     8588    -24464     
+ Misses      16322     8274     -8048     
+ Partials      134        0      -134     

Flag	Coverage Δ
cypress	50.93% <ø> (+0.57%)	⬆️
javascript	?
python	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...explore/components/AdhocMetricEditPopoverTitle.jsx	90.00% <ø> (+25.48%)	⬆️
...uperset-frontend/src/dashboard/util/dnd-reorder.js	0.00% <0.00%> (-100.00%)	⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js	0.00% <0.00%> (-100.00%)	⬇️
...dashboard/components/resizable/ResizableHandle.jsx	0.00% <0.00%> (-100.00%)	⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js	0.00% <0.00%> (-93.48%)	⬇️
...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx	11.76% <0.00%> (-88.24%)	⬇️
...src/dashboard/components/gridComponents/Header.jsx	10.52% <0.00%> (-86.85%)	⬇️
superset-frontend/src/components/IconTooltip.tsx	13.33% <0.00%> (-86.67%)	⬇️
...rc/dashboard/components/gridComponents/Divider.jsx	13.33% <0.00%> (-86.67%)	⬇️
...end/src/SqlLab/components/ExploreResultsButton.jsx	8.00% <0.00%> (-84.00%)	⬇️
... and 872 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4175152...e7e1067. Read the comment docs.

[villebro]

LGTM! thanks for the fix! agreed current designed solution is not ideal. we should invest some design effort in Explore popovers

instead of showing my metrics, it should display the auto generated label

I have similar thoughts - perhaps greyed out autogenerated label, and black if overridden.