Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excel upload menu option is missing from master #13766

Closed
cemremengu opened this issue Mar 24, 2021 · 2 comments
Closed

Excel upload menu option is missing from master #13766

cemremengu opened this issue Mar 24, 2021 · 2 comments
Labels
need:design-review Requires input/approval from a Designer question & help wanted Use Github discussions instead

Comments

@cemremengu
Copy link
Contributor

cemremengu commented Mar 24, 2021 •
edited
Loading

Is excel upload a (undocumented) feature flag? For some reason it is visible in latest docker distribution but not in master.

Checked but couldn't spot any switches in code

Expected results

image

Actual results

image
@cemremengu cemremengu added the #bug Bug report label Mar 24, 2021
@junlincc
Copy link
Member

junlincc commented Mar 26, 2021 •
edited
Loading

Please checkout, #11736 . both should be supported :)

@mihir174 @Steejay we should make it more explicit though

@junlincc junlincc added question & help wanted Use Github discussions instead resolved need:design-review Requires input/approval from a Designer and removed #bug Bug report labels Mar 26, 2021
@cemremengu cemremengu reopened this Mar 26, 2021
@cemremengu
Copy link
Contributor Author

cemremengu commented Mar 26, 2021 •
edited
Loading

Reopening since I don't know your workflow, feel free to close.

As a side note, I think the naming changes in PR #11736 should also be applied to excel upload code since it can be a bit confusing. Created a PR to get started #13805

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need:design-review Requires input/approval from a Designer question & help wanted Use Github discussions instead
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cemremengu @junlincc