Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Text change Allow Data Upload #11736

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Conversation

amitmiran137
Copy link
Member

SUMMARY

today there are 2 ways of uploading data CSV or Excel
config on the database allow_csv_upload applies to both options
so the client facing text should also indicate that

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before:
image
after will include /Excel in the text

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

today there are 2 ways of uploading data CSV or Excel
config on the database allow_csv_upload applies to both options
so the client facing text should also indicate that
@codecov-io
Copy link

codecov-io commented Nov 18, 2020

Codecov Report

Merging #11736 (dc17c6a) into master (7ae8cd0) will decrease coverage by 3.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11736      +/-   ##
==========================================
- Coverage   66.74%   63.10%   -3.65%     
==========================================
  Files         897      443     -454     
  Lines       43463    27271   -16192     
  Branches     4015        0    -4015     
==========================================
- Hits        29009    17209   -11800     
+ Misses      14349    10062    -4287     
+ Partials      105        0     -105     
Flag Coverage Δ
cypress ?
javascript ?
python 63.10% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/mysql.py 79.59% <0.00%> (-12.25%) ⬇️
superset/db_engine_specs/presto.py 73.65% <0.00%> (-8.64%) ⬇️
superset/examples/world_bank.py 97.10% <0.00%> (-2.90%) ⬇️
superset/examples/birth_names.py 96.51% <0.00%> (-2.33%) ⬇️
superset/models/core.py 87.77% <0.00%> (-1.09%) ⬇️
superset/views/core.py 73.70% <0.00%> (-0.48%) ⬇️
superset/connectors/sqla/models.py 91.09% <0.00%> (-0.14%) ⬇️
superset-frontend/src/components/CachedLabel.jsx
superset-frontend/src/showSavedQuery/index.jsx
...rset-frontend/src/common/components/DatePicker.tsx
... and 450 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae8cd0...dc17c6a. Read the comment docs.

Copy link
Member

@bkyryliuk bkyryliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excel is an optional dependency: https://github.com/apache/incubator-superset/blob/master/setup.py#L122
this should probably be behind the feature flag

@amitmiran137
Copy link
Member Author

amitmiran137 commented Nov 18, 2020

@bkyryliuk not sure why you say it is optional if it is available always from the menu
https://github.com/apache/incubator-superset/blob/7ae8cd07cc2942ae99fcf8ae95aba9ffd65682b9/superset/app.py#L364
also there is no existing feature flag that does exits for the upload excel filter

@willbarrett
Copy link
Member

Perhaps we could avoid the issue by calling the option "Allow Data Upload"?

@amitmiran137
Copy link
Member Author

such a brilliant idea ;)
I can do that

@amitmiran137 amitmiran137 changed the title chore: Text change Allow CSV/Excel Upload chore: Text change Allow Data Upload Nov 18, 2020
@villebro villebro merged commit c79dc47 into apache:master Nov 19, 2020
@bkyryliuk
Copy link
Member

@bkyryliuk not sure why you say it is optional if it is available always from the menu
https://github.com/apache/incubator-superset/blob/7ae8cd07cc2942ae99fcf8ae95aba9ffd65682b9/superset/app.py#L364

also there is no existing feature flag that does exits for the upload excel filter

See the link, it is optional pip dependency. That means the vanilla superset installation will not have excel support most likely

auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* chore: Text change Allow CSV/Excel Upload

today there are 2 ways of uploading data CSV or Excel
config on the database allow_csv_upload applies to both options
so the client facing text should also indicate that

* Allow Data Upload
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants