-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Text change Allow Data Upload #11736
Conversation
today there are 2 ways of uploading data CSV or Excel config on the database allow_csv_upload applies to both options so the client facing text should also indicate that
Codecov Report
@@ Coverage Diff @@
## master #11736 +/- ##
==========================================
- Coverage 66.74% 63.10% -3.65%
==========================================
Files 897 443 -454
Lines 43463 27271 -16192
Branches 4015 0 -4015
==========================================
- Hits 29009 17209 -11800
+ Misses 14349 10062 -4287
+ Partials 105 0 -105
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excel is an optional dependency: https://github.com/apache/incubator-superset/blob/master/setup.py#L122
this should probably be behind the feature flag
@bkyryliuk not sure why you say it is optional if it is available always from the menu |
Perhaps we could avoid the issue by calling the option "Allow Data Upload"? |
such a brilliant idea ;) |
See the link, it is optional pip dependency. That means the vanilla superset installation will not have excel support most likely |
* chore: Text change Allow CSV/Excel Upload today there are 2 ways of uploading data CSV or Excel config on the database allow_csv_upload applies to both options so the client facing text should also indicate that * Allow Data Upload
SUMMARY
today there are 2 ways of uploading data CSV or Excel
config on the database allow_csv_upload applies to both options
so the client facing text should also indicate that
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before:
after will include /Excel in the text
TEST PLAN
ADDITIONAL INFORMATION