Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chart] Chart that's using a virtual dataset with an orderby breaks #15693

Closed
rosemarie-chiu opened this issue Jul 14, 2021 · 2 comments · Fixed by #15707
Closed

[chart] Chart that's using a virtual dataset with an orderby breaks #15693

rosemarie-chiu opened this issue Jul 14, 2021 · 2 comments · Fixed by #15707
Assignees
@zhaoyongjie
Labels
#bug Bug report explore:control Related to the controls panel of Explore P1 Priority item - Major preset:QA Preset QA team

Comments

@rosemarie-chiu
Copy link
Contributor

I suspect this is broke by this PR #15343
I have a virtual dataset that is order by a date column in the virtual dataset. It used to work but not anymore.

Expected results

screenshot of how it used to be working
CleanShot 2021-07-14 at 13 53 35

Actual results

It is complaining unknown column used by "order by"
CleanShot 2021-07-14 at 13 56 56
@rosemarie-chiu rosemarie-chiu added the #bug Bug report label Jul 14, 2021
@superset-github-bot superset-github-bot bot added the preset:QA Preset QA team label Jul 14, 2021
@junlincc junlincc added P1 Priority item - Major explore:control Related to the controls panel of Explore labels Jul 14, 2021
@junlincc
Copy link
Member

Issue: Chart that's using a virtual dataset with an orderby breaks

@rosemarie-chiu rosemarie-chiu changed the title [chart] orderby for virtual dataset is broken [chart] Chart that's using a virtual dataset with an orderby breaks Jul 15, 2021
@zhaoyongjie
Copy link
Member

@rosemarie-chiu Could you share this dataset with me? It seems to have a bug with the window function(sum over ....) as a metric.

@zhaoyongjie zhaoyongjie mentioned this issue Jul 15, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhaoyongjie zhaoyongjie

Labels
#bug Bug report explore:control Related to the controls panel of Explore P1 Priority item - Major preset:QA Preset QA team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use expected label in metrics map zhaoyongjie/incubator-superset
3 participants
@zhaoyongjie @rosemarie-chiu @junlincc