Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing orderby in query on the nvd3 timeseries chart #15343

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Jun 24, 2021

SUMMARY

currently, order by clause must be explicitly selected in the explore control, and cannot send asc query to database.

this PR fixed

  • make the first metric as the main metric for implicit orderby column
  • ensure asc orderby

Partially fixed #13792

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after

image

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: [chart]Time Series Bar Chart does not sort #13792
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #15343 (89dfcbe) into master (ab153e6) will increase coverage by 0.09%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15343      +/-   ##
==========================================
+ Coverage   77.14%   77.24%   +0.09%     
==========================================
  Files         973      973              
  Lines       50473    50510      +37     
  Branches     6183     6183              
==========================================
+ Hits        38938    39017      +79     
+ Misses      11329    11287      -42     
  Partials      206      206              
Flag Coverage Δ
hive 81.44% <83.33%> (+0.02%) ⬆️
mysql 81.71% <83.33%> (+0.02%) ⬆️
postgres 81.73% <83.33%> (+0.02%) ⬆️
presto 81.43% <83.33%> (?)
python 82.26% <83.33%> (+0.18%) ⬆️
sqlite 81.36% <83.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/viz.py 56.52% <66.66%> (+0.05%) ⬆️
superset/utils/core.py 89.09% <100.00%> (+0.04%) ⬆️
superset/views/core.py 75.54% <0.00%> (-0.04%) ⬇️
superset/errors.py 100.00% <0.00%> (ø)
superset/views/sql_lab.py 60.68% <0.00%> (ø)
superset/models/core.py 90.02% <0.00%> (+0.26%) ⬆️
superset/sql_lab.py 83.62% <0.00%> (+1.39%) ⬆️
superset/connectors/sqla/models.py 89.87% <0.00%> (+1.41%) ⬆️
superset/connectors/connector_registry.py 83.33% <0.00%> (+4.64%) ⬆️
superset/db_engine_specs/presto.py 90.31% <0.00%> (+5.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab153e6...89dfcbe. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit fae4531 into apache:master Jun 24, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chart]Time Series Bar Chart does not sort
3 participants