fix: revert default series sort-by metric #17236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 26, 2021
john-bodley
changed the title
john-bodley
force-pushed
the
john-bodley--fix-series-sort-by-limit
branch
from
1a58a10
to
86ddaf8
Compare
john-bodley
force-pushed
the
john-bodley--fix-series-sort-by-limit
branch
2 times, most recently
from
f5d8a45
to
9652004
Compare
john-bodley
commented
Oct 26, 2021
| @@ -92,7 +92,7 @@ export const D3_FORMAT_OPTIONS = [ | |||
|
|
|||
| const ROW_LIMIT_OPTIONS = [10, 50, 100, 250, 500, 1000, 5000, 10000, 50000]; | |||
|
|
|||
| const SERIES_LIMITS = [0, 5, 10, 25, 50, 100, 500]; | |||
| const SERIES_LIMITS = [5, 10, 25, 50, 100, 500]; | |||
There was a problem hiding this comment.
Consistent with apache-superset/superset-ui#1430. Note I'm unsure why things are defined in multiple places.
Codecov Report
@@ Coverage Diff @@
## master #17236 +/- ##
=======================================
Coverage 76.95% 76.95%
=======================================
Files 1038 1037 -1
Lines 55612 55609 -3
Branches 7590 7588 -2
=======================================
- Hits 42798 42796 -2
+ Misses 12564 12563 -1
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
john-bodley
force-pushed
the
john-bodley--fix-series-sort-by-limit
branch
from
9652004
to
8f659aa
Compare
john-bodley
force-pushed
the
john-bodley--fix-series-sort-by-limit
branch
from
8f659aa
to
8fbdc32
Compare
john-bodley
changed the title
|
@zhaoyongjie any thoughts/comments regarding this in light of the comments I added here? |
etr2460
approved these changes
Nov 3, 2021
9 tasks
AAfghahi
pushed a commit
that referenced
this pull request
Jan 10, 2022
…ries limit (#17236) Co-authored-by: John Bodley <john.bodley@airbnb.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR is one of a slew to the apache/superset and apache-superset/superset-ui repos to revert pseudo recent changes to the series restrictions for high cardinality groupings. For more context please refer to this Slack thread in the #committers channel.
Specifically this PR reverts #15343 (and more), i.e., does not fallback to the first selected metric and requires the user to specify a sort-by metric for improved UX, i.e., it was not apparent to the user from the UI how the sorting was happening. Furthermore said change was actually a breaking change but was not protected with a feature flag.
Initially I added logic for an XOR check that required either neither or both the series sort-by and limit needed to be provided, but this would be a breaking change—in addition to thinking about how this should work with the table row limit—and thus I felt this would be better handled at a later stage.
Related PRs:
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION