This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
fix: revert default series limit and update eligible choices #1430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏠 Internal
This PR is one of a slew to the apache/superset and apache-superset/superset-ui repos to revert pseudo recent changes to the series restrictions for high cardinality groupings. For more context please refer to this Slack thread in the #committers channel.
Specifically this PR reverts #1033 (and more) to ensure there is no default if undefined given that:
Select ...
is rendered, that a default is set.0
which is misleading (and thus removed as an option) given that in actually it is akin to having no limits as the joined subquery logic is not invoked.Furthermore said change was actually a breaking change but was not protected with a feature flag.
Related PRs: