Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native filter]select filter on dashboard with NULL values fails #16438

Closed
stevensuting opened this issue Aug 25, 2021 · 4 comments · Fixed by #16468
Closed

[native filter]select filter on dashboard with NULL values fails #16438

stevensuting opened this issue Aug 25, 2021 · 4 comments · Fixed by #16468
Assignees
Labels
#bug Bug report P3 Priority item - Normal v1.3

Comments

@stevensuting
Copy link

When upgrading from 1.1 to 1.3, dashboards that use Native filter are unusable.
Screenshot 2021-08-24 at 9 43 56 PM

On clicking see more:
Native filters 1 1 to 1 3 upgrade

Expected results

The upgrade should not disrupt the filters.

Environment

(please complete the following information):

  • superset version: 1.3
  • python version: 3.9
  • installed via pip install.
@stevensuting stevensuting added the #bug Bug report label Aug 25, 2021
@villebro
Copy link
Member

Thanks for reporting @stevensuting ! We will look what it would take to fix this for 1.3.1!

@villebro
Copy link
Member

@stevensuting I'm looking for minimal reproduction steps for this bug. Does this sound accurate?

  • Spin up a 1.1 version of Superset
  • Create a select filter on a dashboard
  • Upgrade to 1.3
  • Go into dashboard that was created with 1.1
  • See error message

@junlincc
Copy link
Member

@villebro @jinghua-qa i think we should test version upgrade to make sure not only the new version works, but also a smooth upgrade from an older version.

@junlincc junlincc added rush! Requires immediate attention and removed rush! Requires immediate attention labels Aug 26, 2021
@junlincc junlincc changed the title Native filter issue when upgrading from 1.1 to 1.3 [native filter]select filter on dashboard with NULL values fails Aug 26, 2021
@junlincc junlincc added the P3 Priority item - Normal label Aug 26, 2021
@villebro
Copy link
Member

I can confirmed that #16468 fixes this (falls back to defaults for filter-specific control values):

BEFORE

image

AFTER

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report P3 Priority item - Normal v1.3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants