-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(native-filters): handle undefined control value gracefully #16468
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16468 +/- ##
=======================================
Coverage 76.63% 76.64%
=======================================
Files 1002 1002
Lines 53637 53647 +10
Branches 6853 6857 +4
=======================================
+ Hits 41104 41116 +12
+ Misses 12294 12292 -2
Partials 239 239
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* upstream/master: fix: create example DB if needed (apache#16451) fix(native-filters): add handle undefined control value gracefully (apache#16468) Revert "chore: Changes the DatabaseSelector to use the new Select component (apache#16334)" (apache#16478) fix(explore): JS error for creating new metrics from columns (apache#16477) fix: queryEditor bug (apache#16452) docs: make code snippet usable with required imports (apache#16473) perf(dashboard): decouple redux props from dashboard components (apache#16421) perf(dashboard): reduce number of rerenders of Charts (apache#16444)
SUMMARY
If
filter.controlValues
isundefined
(the case of metadata from when native filters wasn't yet stable), the Filter Tab will crash. This ensures that the component doesn't crash ifcontrolValues
isn't defined. This was the only case ofcontrolValues
that I was able to find where we didn't check for?
.Closes #16438
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION