Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: queryEditor bug #16452

Merged
merged 2 commits into from
Aug 26, 2021
Merged

fix: queryEditor bug #16452

merged 2 commits into from
Aug 26, 2021

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented Aug 25, 2021

SUMMARY

This is helps solve an issue where the autocomplete causes your sql editor to cause you to lose sql and seem jumpy.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Try typing quickly in sql lab editor with a throttled connection. The typing should seem seamless.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho
Copy link
Member

This may also relate to #15995

@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 25, 2021
@eschutho
Copy link
Member

cc @graceguo-supercat

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #16452 (32edc02) into master (db11c3e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 32edc02 differs from pull request most recent head d3b433b. Consider uploading reports for the commit d3b433b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16452   +/-   ##
=======================================
  Coverage   76.63%   76.63%           
=======================================
  Files        1002     1002           
  Lines       53635    53633    -2     
  Branches     6851     6849    -2     
=======================================
- Hits        41101    41100    -1     
+ Misses      12295    12294    -1     
  Partials      239      239           
Flag Coverage Δ
javascript 70.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 58.60% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db11c3e...d3b433b. Read the comment docs.

@yousoph
Copy link
Member

yousoph commented Aug 26, 2021

/testenv up

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://52.13.113.100:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@betodealmeida also collaborated on this

@eschutho eschutho merged commit ee2eccd into apache:master Aug 26, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@eschutho eschutho deleted the ch22691_jumpyCursor branch August 26, 2021 22:20
@rosemarie-chiu
Copy link
Contributor

🏷 2021.34

@mistercrunch mistercrunch added 🍒 1.3.1 🍒 1.3.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.34 size/M v1.3 🍒 1.3.1 🍒 1.3.2 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants