-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to filter dimension in chart by double click - after update from Supserset 2.0.1 to 2.1.0 #23735
Comments
Same issue here. |
Same issue too. |
It's very convenient. When it will be fixed? |
Well, I'm trying to find out the reason this feature isn't working. I'm not a frontend developer and sorry for possible confusing, but here are some results: superset/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx Line 59 in 357745f
In 2.0.1 echartRef will be equal to ChartInstance object, but in 2.1.0 you will get undefined @villebro I see some of your activities in this module. Do you have any ideas how to fix this bug? Could you share your thoughts, please? As you can see, there are plenty of "DoubleClick feature" users :) |
@rusackas thank you for reply! We are excited to try this newfeature with 'All' and 'Invert' buttons! But I still don't get it... UPD: Here is the correct link to the function: superset/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx Line 72 in 357745f
|
Yep, I see that in the code, and it looks like it ought to work, but I don't see it actually doing anything. That probably ought to be debugged or removed, one way or the other. |
@rusackas yep, it ought to work and it was OK in 2.0.1, but not in 2.1.0: I've tryed to debug this feature, but then I got stuck. You can debug this in the next steps:
This is how it was looking like in 2.0.1: In 2.1.0 we have undefined. This is because the echartRef is null, which one is defined a little above. If you have any ideas about this bug, please share :) I guess we can re-open this issue, because it's not deprecated and it would be very helpful for us to use it until 3.0 release |
Just for the record: this is where the feature is described and implemented previously: |
@rusackas Can we re-open the issue, please? |
This was fixed in #24477 and will be available in 3.0 |
@PrinceGallywix you can try to add ref={echartRef} to fix issue. superset/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx Line 294 in 357745f
<Echart
ref={echartRef}
refs={refs}
height={height - extraControlHeight}
width={width}
echartOptions={echartOptions}
eventHandlers={eventHandlers}
zrEventHandlers={zrEventHandlers}
selectedValues={selectedValues}
/> |
After update to 2.1.0 from 2.0.1 we are unable to filter one line on chart with multiple dimensions via double clicking on it. (Does not depends on chart type: for example, Time-series Area chart and time-series bar chart had been tested).
It was very useful feature and all of our charts were depended on it (on version 2.0.1) - our users would simply double click on a single line to explore certain tendency rather then disabling every other line via navigation bar on top-right of the chart.
Are there any options to turn this feature back on?
How to reproduce the bug
Expected results
Only chosen dimension left on a chart
Actual results
Nothing happens, there are still multiple dimensions on a chart.
Environment
Checklist
The text was updated successfully, but these errors were encountered: