Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md is missing mysql_config command being a developer dependency #7399

Closed
rjurney opened this issue Apr 28, 2019 · 6 comments
Closed
Labels
!deprecated-label:bug Deprecated label - Use #bug instead inactive Inactive for >= 30 days

Comments

@rjurney
Copy link
Contributor

rjurney commented Apr 28, 2019

requirements-dev.txt requires mysqlclient which requires the OS dependency the mysql_config command. CONTRIBUTING.md does not let the new developer know this.

Expected results

pip install -r requirements-dev.txt

Expect: success!

Actual results

mysql_config not found!

How to reproduce the bug

  1. Have a system without the mysql_config command on it
  2. Run: pip install -r requirements-dev.txt
  3. See error

Environment

  • OS: Ubuntu 18.04 and OS X 10.14.4
  • superset version: [release--0.31, b3aa5633]
  • python version: 3.6.7, 3.6.8, 3.7.3

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • [*] I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • [*] I have reproduced the issue with at least the latest released version of superset.
  • [*] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.72. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the !deprecated-label:bug Deprecated label - Use #bug instead label Apr 28, 2019
@mistercrunch
Copy link
Member

I found that pip install mysqlclient installs a newer version that works. I think we just need to bump the version in requirements-dev.txt

$ pip freeze | grep -i mysql
mysqlclient==1.4.2.post1

@rjurney
Copy link
Contributor Author

rjurney commented May 4, 2019

@mistercrunch Updated so in master pull #7426

@stale
Copy link

stale bot commented Jul 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Jul 3, 2019
@zhaoyongjie
Copy link
Member

zhaoyongjie commented Jul 3, 2019 via email

@stale stale bot removed the inactive Inactive for >= 30 days label Jul 3, 2019
@stale
Copy link

stale bot commented Sep 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Sep 1, 2019
@stale stale bot closed this as completed Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead inactive Inactive for >= 30 days
Projects
None yet
Development

No branches or pull requests

3 participants