-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump pydruid to 0.6.0 #10014
fix: bump pydruid to 0.6.0 #10014
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10014 +/- ##
==========================================
+ Coverage 65.59% 68.85% +3.25%
==========================================
Files 585 583 -2
Lines 31046 31019 -27
Branches 3277 3175 -102
==========================================
+ Hits 20364 21357 +993
+ Misses 10501 9552 -949
+ Partials 181 110 -71
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good to me, we can let CI check the other python envs. the only thing to fix is the PR title (make sure it adheres to the correct format so that the PRLint checker passes)
@karen-pal did you try 0.6.0? While it doesn't introduce any new features, its requirements are better aligned with the current Superset dependencies. For instance, Pandas is unpinned from the old |
I haven't, since I don't really use pydruid/druid. I wanted to bump the version to the one that started supporting python3.7 to stop the installation from crashing. I could bump it to 0.6.0 though! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: we should be consistent in how we pin versions (==
vs >=
).
* bump pydruid to 0.5.11 * bump pydruid to 0.6.0
SUMMARY
Bump version of pydruid: 0.5.9 to 0.6.0
Version 0.5.9 causes installation errors with python 3.7 when running
pip install -r requirements-dev.txt
. This is fixed by bumping said version.TEST PLAN
ADDITIONAL INFORMATION