-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove QueryView (ModelView) #10162
Conversation
Some odd test failures on this one. I'd change @john-bodley @etr2460 @betodealmeida @bkyryliuk are these endpoints in use by your organizations? Trying to cast a wide net early... |
Could you share an example of the URLs that are removed? |
we don't use those, thanks for the cleanup! |
1 similar comment
we don't use those, thanks for the cleanup! |
4e2622d
to
72c539c
Compare
Codecov Report
@@ Coverage Diff @@
## master #10162 +/- ##
==========================================
+ Coverage 70.63% 71.69% +1.06%
==========================================
Files 601 405 -196
Lines 32286 13312 -18974
Branches 3275 3275
==========================================
- Hits 22804 9544 -13260
+ Misses 9376 3662 -5714
Partials 106 106
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
72c539c
to
7dce4b7
Compare
7dce4b7
to
e9782d9
Compare
@etr2460 this removes Can I get a stamp? |
* chore: deprecate QueryView (ModelView) * lint * fix unit tests
SUMMARY
This is not needed anymore as we have the "Query Search" page, and the
/api/v1/query
REST endpoints.