Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove QueryView (ModelView) #10162

Merged
merged 3 commits into from
Jul 21, 2020
Merged

Conversation

mistercrunch
Copy link
Member

SUMMARY

This is not needed anymore as we have the "Query Search" page, and the /api/v1/query REST endpoints.

@willbarrett
Copy link
Member

Some odd test failures on this one. I'd change deprecate to remove in the PR title - this isn't deprecation, which implies prior notice of removal. This is deleting API endpoints.

@john-bodley @etr2460 @betodealmeida @bkyryliuk are these endpoints in use by your organizations? Trying to cast a wide net early...

@etr2460
Copy link
Member

etr2460 commented Jun 25, 2020

Could you share an example of the URLs that are removed?

@bkyryliuk
Copy link
Member

Some odd test failures on this one. I'd change deprecate to remove in the PR title - this isn't deprecation, which implies prior notice of removal. This is deleting API endpoints.

@john-bodley @etr2460 @betodealmeida @bkyryliuk are these endpoints in use by your organizations? Trying to cast a wide net early...

we don't use those, thanks for the cleanup!

1 similar comment
@bkyryliuk
Copy link
Member

Some odd test failures on this one. I'd change deprecate to remove in the PR title - this isn't deprecation, which implies prior notice of removal. This is deleting API endpoints.

@john-bodley @etr2460 @betodealmeida @bkyryliuk are these endpoints in use by your organizations? Trying to cast a wide net early...

we don't use those, thanks for the cleanup!

@codecov-commenter
Copy link

Codecov Report

Merging #10162 into master will increase coverage by 1.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10162      +/-   ##
==========================================
+ Coverage   70.63%   71.69%   +1.06%     
==========================================
  Files         601      405     -196     
  Lines       32286    13312   -18974     
  Branches     3275     3275              
==========================================
- Hits        22804     9544   -13260     
+ Misses       9376     3662    -5714     
  Partials      106      106              
Flag Coverage Δ
#cypress 55.63% <ø> (+0.02%) ⬆️
#javascript 59.61% <ø> (ø)
#python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/SqlLab/components/QueryAutoRefresh.jsx 65.90% <0.00%> (-6.82%) ⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js 62.60% <0.00%> (ø)
superset/views/database/filters.py
superset/models/helpers.py
superset/dashboards/commands/exceptions.py
superset/migrations/env.py
superset/utils/cache.py
superset/utils/import_datasource.py
superset/views/utils.py
superset/utils/core.py
... and 188 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73797b8...72c539c. Read the comment docs.

@mistercrunch mistercrunch changed the title chore: deprecate QueryView (ModelView) chore: remove QueryView (ModelView) Jul 21, 2020
@mistercrunch
Copy link
Member Author

@etr2460 this removes /queryview/read

Can I get a stamp?

@mistercrunch mistercrunch merged commit 85169f2 into apache:master Jul 21, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* chore: deprecate QueryView (ModelView)

* lint

* fix unit tests
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants