feat: add configuration for Presto cursor poll interval #10191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkyryliuk
reviewed
Jun 29, 2020
superset/db_engine_specs/presto.py
Outdated
| @@ -729,6 +732,11 @@ def get_create_view( | |||
| def handle_cursor(cls, cursor: Any, query: Query, session: Session) -> None: | |||
| """Updates progress information""" | |||
| query_id = query.id | |||
| poll_interval = ( | |||
| query.database.get_extra() | |||
There was a problem hiding this comment.
it would be nice to add a property connect_args to the db object as this code becomes a bit repetitive:
https://github.com/apache/incubator-superset/search?q=connect_args&unscoped_q=connect_args
and by the way connect args should be part of the engine_params
etr2460
force-pushed
the
erik-ritter--presto-poll-config
branch
from
c4aa6d1
to
547b1c7
Compare
bkyryliuk
approved these changes
Jun 30, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Uses the poll interval defined in the database's
connect_args(if there) to set the polling interval for Presto's cursor. This will align the polling between Superset and PyHive, hopefully resulting in less downtime on shorter/synchronous queries (if the admin chooses)TEST PLAN
CI, unfortunately this is pretty hard to write a unit test for :/
ADDITIONAL INFORMATION
to: @john-bodley @villebro @bkyryliuk @tooptoop4