refactor: database API OpenAPI spec and location #10303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willbarrett
reviewed
Jul 15, 2020
willbarrett
approved these changes
Jul 15, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* refactor: database API OpenAPI spec and location * fix isort and license * fix description
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Cuts verbosity down from OpenAPI spec, using marshmallow schemas to define the API response.
Also changes the database API location, and cuts the cord from
DatabaseMixinshared betweenModelViewandModelRestApi.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
New improved spec for
api/v1/database/{pk}/table/{table_name}/{schema_name}/TEST PLAN
Manually check OpenAPI spec on swagger view
ADDITIONAL INFORMATION