feat: update dataset editor modal

[lilykuang]

SUMMARY

• reuse dataset editing modal from explore
• convert ChangeDatasourceModal and DatasourceModal to use hooks
• test has failed after convert to hooks but I will update test after this pr merge

Future improvement:

• convert DatasourceEditor to use hooks

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov-commenter]

Codecov Report

Merging #10347 into master will decrease coverage by 0.41%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master   #10347      +/-   ##
==========================================
- Coverage   70.25%   69.83%   -0.42%     
==========================================
  Files         605      196     -409     
  Lines       32377    19070   -13307     
  Branches     3271        0    -3271     
==========================================
- Hits        22745    13317    -9428     
+ Misses       9522     5753    -3769     
+ Partials      110        0     -110     

Flag	Coverage Δ
#cypress	?
#javascript	?
#python	69.83% <88.88%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/datasets/api.py	92.14% <ø> (ø)
superset/connectors/druid/models.py	82.48% <66.66%> (-0.06%)	⬇️
superset/connectors/sqla/models.py	89.54% <100.00%> (+0.09%)	⬆️
.../dashboard/util/charts/getEffectiveExtraFilters.ts
...shboard/util/charts/getFormDataWithExtraFilters.ts
...nd/src/dashboard/util/getComponentWidthFromDrop.js
superset-frontend/src/components/CachedLabel.jsx
...rontend/src/views/CRUD/dashboard/DashboardList.tsx
superset-frontend/src/components/SearchInput.tsx
...ponents/filterscope/renderFilterScopeTreeNodes.jsx
... and 398 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f56cd5...7aa3e25. Read the comment docs.

[nytai]

this looks like a redundant check

[nytai]

overall LGTM, just 1 comment

[nytai]

@lilykuang Looks like cypress is failing on this test: https://github.com/preset-io/incubator-superset/blob/3445710267cef7cbbee28b2a49785723fc6d3247/superset-frontend/cypress-base/cypress/integration/explore/control.test.ts#L34

It looks like something that could have been broken with this change

[mistercrunch]

Not a huge deal, but let's use git mv to keep the history of the file attached to it! You can fix it quickly with

mv superset-frontend/src/datasource/ChangeDatasourceModal.tsx /tmp
git checkout HEAD^ superset-frontend/src/datasource/ChangeDatasourceModal.tsx
git mv superset-frontend/src/datasource/ChangeDatasourceModal.jsx superset-frontend/src/datasource/ChangeDatasourceModal.tsx
mv /tmp/ChangeDatasourceModal.tsx superset-frontend/src/datasource/

[lilykuang]

I couldn't get moving history working for git

[lilykuang]

@lilykuang Looks like cypress is failing on this test: https://github.com/preset-io/incubator-superset/blob/3445710267cef7cbbee28b2a49785723fc6d3247/superset-frontend/cypress-base/cypress/integration/explore/control.test.ts#L34

It looks like something that could have been broken with this change
@nytai The superset/explore page was broken after I updated put endpoint to use api/v1/. It have to be changed back to old endpoint for both dataset list and explore to work.