style: SIP-34 control-label #10381
Merged
style: SIP-34 control-label #10381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
sip34-control-label
branch
from
b53f533
to
a24fd4c
Compare
mistercrunch
commented
Jul 21, 2020
| @@ -220,7 +220,7 @@ | |||
| ); | |||
|
|
|||
| // ** `.form-group` margin | |||
| @form-group-margin-bottom: 10px; | |||
| @form-group-margin-bottom: 16px; | |||
There was a problem hiding this comment.
moving towards the 8px system
There was a problem hiding this comment.
I might sweep this (and others) up with a @grid-unit variable... no need to worry for this PR though.
rusackas
approved these changes
Jul 21, 2020
|
Impacts #8976 |
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
Before