style: add fade transition to bottom border on navbar menu items #10402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10402 +/- ##
==========================================
- Coverage 70.41% 65.30% -5.12%
==========================================
Files 604 605 +1
Lines 32429 32410 -19
Branches 3298 3295 -3
==========================================
- Hits 22836 21164 -1672
- Misses 9487 11061 +1574
- Partials 106 185 +79
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mistercrunch
requested changes
Jul 23, 2020
etr2460
reviewed
Jul 23, 2020
rusackas
reviewed
Jul 23, 2020
rusackas
reviewed
Jul 23, 2020
Yeah, welcome to the party! |
|
Impacts #8976 |
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
…che#10402) * Add fade transition to bottom border on navbar menu items * lint fix * use theme variables * fix spec
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Update the navbar's current menu item hover state to fade in the bottom border
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
ADDITIONAL INFORMATION