chore: TypeScript <Label /> #10494
Merged
chore: TypeScript <Label /> #10494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe I've fixed last test... if this gets merged in, remind me to open another PR and use the new |
Codecov Report
@@ Coverage Diff @@
## master #10494 +/- ##
==========================================
- Coverage 63.64% 59.44% -4.21%
==========================================
Files 764 766 +2
Lines 36165 36180 +15
Branches 3438 3441 +3
==========================================
- Hits 23019 21507 -1512
- Misses 13033 14482 +1449
- Partials 113 191 +78
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Ugh... this python pre-commit hook is failing on a random text file. I'm fixing it in this in #10515 |
|
🏷 storybook |
rusackas
approved these changes
Aug 5, 2020
|
I was just working with labels and wanted to make some tweaks. Having this in place would make it easy to add more variants |
rusackas
reviewed
Aug 6, 2020
| Default: 'default', | ||
| danger: 'danger', | ||
| warning: 'warning', | ||
| cuccess: 'success', |
There was a problem hiding this comment.
Suggested change
| cuccess: 'success', | |
| success: 'success', |
There was a problem hiding this comment.
well that wasn't a success
Ofeknielsen
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Oct 5, 2020
* chore: TypeScript <Label /> * rebase * chore: TypeScript <Label /> * rebase * A bunch o' test fixes. One more to go! * helper for mountying Emotional components with Enzyme * asf license * fixed last test, some linting * improve the storybook * Adressing comments Co-authored-by: Evan Rusackas <evan@preset.io>
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* chore: TypeScript <Label /> * rebase * chore: TypeScript <Label /> * rebase * A bunch o' test fixes. One more to go! * helper for mountying Emotional components with Enzyme * asf license * fixed last test, some linting * improve the storybook * Adressing comments Co-authored-by: Evan Rusackas <evan@preset.io>
mistercrunch
added
the
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried @rusackas 's approach of bringing a react-bootstrap component in Storybook just for fun.
One thought is around the fact that labels are used in controls, and that it calls for eventually having to refactor components into its own package that other packages can depend on.