Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make SQL-based alert email links user friendly #10519

Merged
merged 2 commits into from
Aug 4, 2020

Conversation

JasonD28
Copy link
Contributor

@JasonD28 JasonD28 commented Aug 4, 2020

SUMMARY

The links in SQL-based alert emails were not user friendly, i.e. local:####/superset. This PR makes the links user friendly based on WEBDRIVER_BASEURL_USER_FRIENDLY in config.py

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

  • local test
  • dropbox staging
  • dropbox production

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI

@@ -580,13 +580,15 @@ def deliver_alert(alert_id: int, recipients: Optional[str] = None) -> None:
"Superset.slice", slice_id=alert.slice.id, standalone="true"
)
screenshot = ChartScreenshot(chart_url, alert.slice.digest)
cache_key = screenshot.cache_key()
image_url = get_url_path(
Copy link
Contributor Author

@JasonD28 JasonD28 Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkyryliuk bkyryliuk merged commit 0d91b3e into apache:master Aug 4, 2020
Ofeknielsen pushed a commit to ofekisr/incubator-superset that referenced this pull request Oct 5, 2020
* make urls user friendly

* formatting

Co-authored-by: Jason Davis <@dropbox.com>
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* make urls user friendly

* formatting

Co-authored-by: Jason Davis <@dropbox.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants