Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misaligned LimitControl buttons and port jsx->tsx #10529

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

mistercrunch
Copy link
Member

Screen Shot 2020-08-05 at 10 03 08 PM

closes: #10525

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2020

Codecov Report

Merging #10529 into master will decrease coverage by 4.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10529      +/-   ##
==========================================
- Coverage   63.75%   59.06%   -4.69%     
==========================================
  Files         767      354     -413     
  Lines       36269    22834   -13435     
  Branches     3426        0    -3426     
==========================================
- Hits        23122    13487    -9635     
+ Misses      13033     9347    -3686     
+ Partials      114        0     -114     
Flag Coverage Δ
#cypress ?
#javascript ?
#python 59.06% <ø> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/mysql.py 79.16% <0.00%> (-12.50%) ⬇️
superset/db_engine_specs/presto.py 70.56% <0.00%> (-12.14%) ⬇️
superset/views/database/mixins.py 80.70% <0.00%> (-1.76%) ⬇️
superset/models/core.py 86.38% <0.00%> (-1.12%) ⬇️
superset/connectors/sqla/models.py 89.98% <0.00%> (-0.30%) ⬇️
superset/views/core.py 74.29% <0.00%> (-0.25%) ⬇️
...dashboard/components/gridComponents/new/NewRow.jsx
.../src/dashboard/util/getFilterScopeFromNodesTree.js
superset-frontend/src/components/EditableTitle.tsx
...t-frontend/src/components/Select/OnPasteSelect.jsx
... and 408 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 363abfa...b931ee7. Read the comment docs.

@mistercrunch mistercrunch force-pushed the fix_row_limit branch 2 times, most recently from ef7d3e4 to b931ee7 Compare August 7, 2020 06:07
@mistercrunch mistercrunch merged commit 613dd12 into apache:master Aug 10, 2020
@mistercrunch mistercrunch deleted the fix_row_limit branch August 10, 2020 22:35
Ofeknielsen pushed a commit to ofekisr/incubator-superset that referenced this pull request Oct 5, 2020
* fix: misaligned LimitControl buttons and port jsx->tsx

* addressed comments
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* fix: misaligned LimitControl buttons and port jsx->tsx

* addressed comments
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Row Limit popover in SQL Lab is oddly formated
3 participants