Associate version to entry files #1060

vera-liu · 2016-09-02T05:38:09Z

Not sure if I did the right steps for testing:

Make changes in js file, update the version number in package.json
npm install under assets
npm run dev (without this step the new js files are not generated by webpack, is this right?)
python setup.py
caravel db upgrade
rerun caravel server
Changes reflect in page on non-hard refresh

vera-liu · 2016-09-02T05:39:34Z

caravel/assets/webpack.config.js

@@ -7,6 +7,11 @@ const APP_DIR = path.resolve(__dirname, './');
 // output dir
 const BUILD_DIR = path.resolve(__dirname, './dist');

+const fs = require('fs');
+const contents = fs.readFileSync('package.json');
+const JSONObject = JSON.parse(contents);


Somehow this part did not re-run when js file/package.json is changed, not sure when exactly does webpack reload its config.js file

I think it's only expected to run when an npm run (...) command is executed

mistercrunch · 2016-09-06T19:28:12Z

caravel/assets/webpack.config.js

@@ -19,7 +24,7 @@ const config = {
  },
  output: {
    path: BUILD_DIR,
-    filename: '[name].entry.js',
+    filename: '[name].' + VERSION_STRING + '.entry.js',


optional nit, equivalent to :

`[name].${VERSION_STRING}.entry.js`

+1, nice es6 syntax.
https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Template_literals

mistercrunch · 2016-09-06T19:32:38Z

A few minor nits, but otherwise LGTM. Oh and please fix the Code Climate issue!

ascott · 2016-09-06T19:35:07Z

caravel/assets/webpack.config.js

@@ -7,6 +7,11 @@ const APP_DIR = path.resolve(__dirname, './');
 // output dir
 const BUILD_DIR = path.resolve(__dirname, './dist');

+const fs = require('fs');


let's put all our require statements at the top of the file

ascott · 2016-09-06T19:59:28Z

should package.json version be the same as caravel version?

using this method we would need to remember to update the package.json version with any js change. this would invalidate the cache on ALL of the js files and not just on the files that changed. not quite what we want to do here.

essentially, we want the filename to update if the file changed, and to stay the same if the contents did not change. we should do this for the css files as well as the js files. i don't think we should need to pull the version from python. we should be able to achieve this using webpack and hashes.

here's a good article on how to do this using webpack: https://medium.com/@okonetchnikov/long-term-caching-of-static-assets-with-webpack-1ecb139adb95

mistercrunch · 2016-09-15T19:25:50Z

LGTM

ascott · 2016-09-15T21:43:25Z

nice work! 👍

* Associate version to entry files * Modified path joins for configs * Made changes based on comments

…1205) * create structure for new forked explore view (#1099) * create structure for new forked explore view * update component name * add bootstrap data pattern * remove console.log * Associate version to entry files (#1060) * Associate version to entry files * Modified path joins for configs * Made changes based on comments * Created store and reducers (#1108) * Created store and reducers * Added spec * Modifications based on comments * Explore control panel components: Chart control, Time filter, SQL, GroupBy and Filters * Modifications based on comments

* Explore control panel - Chart control, TimeFilter, GroupBy, Filters (#1205) * create structure for new forked explore view (#1099) * create structure for new forked explore view * update component name * add bootstrap data pattern * remove console.log * Associate version to entry files (#1060) * Associate version to entry files * Modified path joins for configs * Made changes based on comments * Created store and reducers (#1108) * Created store and reducers * Added spec * Modifications based on comments * Explore control panel components: Chart control, Time filter, SQL, GroupBy and Filters * Modifications based on comments * accommodate old and new explore urls * move bootstrap data up in scope * fix code climate issues * fix long lines * fix syntax error

…pache#1205) * create structure for new forked explore view (apache#1099) * create structure for new forked explore view * update component name * add bootstrap data pattern * remove console.log * Associate version to entry files (apache#1060) * Associate version to entry files * Modified path joins for configs * Made changes based on comments * Created store and reducers (apache#1108) * Created store and reducers * Added spec * Modifications based on comments * Explore control panel components: Chart control, Time filter, SQL, GroupBy and Filters * Modifications based on comments

* Explore control panel - Chart control, TimeFilter, GroupBy, Filters (#1205) * create structure for new forked explore view (#1099) * create structure for new forked explore view * update component name * add bootstrap data pattern * remove console.log * Associate version to entry files (#1060) * Associate version to entry files * Modified path joins for configs * Made changes based on comments * Created store and reducers (#1108) * Created store and reducers * Added spec * Modifications based on comments * Explore control panel components: Chart control, Time filter, SQL, GroupBy and Filters * Modifications based on comments * Added access check + Druid in endpoint * pull grains to constants * Switch explore.html to old version

…pache#1205) * create structure for new forked explore view (apache#1099) * create structure for new forked explore view * update component name * add bootstrap data pattern * remove console.log * Associate version to entry files (apache#1060) * Associate version to entry files * Modified path joins for configs * Made changes based on comments * Created store and reducers (apache#1108) * Created store and reducers * Added spec * Modifications based on comments * Explore control panel components: Chart control, Time filter, SQL, GroupBy and Filters * Modifications based on comments

vera-liu added help wanted labels Sep 2, 2016

vera-liu reviewed Sep 2, 2016
View reviewed changes

vera-liu force-pushed the vliu_add_version_to_entry branch from b50208a to a043a34 Compare September 2, 2016 17:05

mistercrunch reviewed Sep 6, 2016
View reviewed changes

ascott reviewed Sep 6, 2016
View reviewed changes

ascott added airbnb Airbnb related ui and removed help wanted labels Sep 7, 2016

vera-liu added 2 commits September 7, 2016 13:19

Associate version to entry files

aa810ff

Modified path joins for configs

79942e0

vera-liu force-pushed the vliu_add_version_to_entry branch 3 times, most recently from ef493e8 to 8f883b5 Compare September 7, 2016 20:23

Made changes based on comments

76b9bc5

vera-liu force-pushed the vliu_add_version_to_entry branch from 8f883b5 to 76b9bc5 Compare September 7, 2016 21:02

vera-liu added 2 commits September 7, 2016 17:00

Merge branch 'master' into vliu_add_version_to_entry

c2276e6

Merge branch 'master' into vliu_add_version_to_entry

dc14d5b

Merge branch 'master' into vliu_add_version_to_entry

e4ae879

vera-liu merged commit 2432c31 into apache:master Sep 16, 2016

vera-liu mentioned this pull request Sep 16, 2016

Associate entry files to version number #898

Closed

dennisobrien pushed a commit to dennisobrien/caravel that referenced this pull request Sep 19, 2016

Associate version to entry files (apache#1060)

c4458ee

* Associate version to entry files * Modified path joins for configs * Made changes based on comments

vera-liu added a commit to vera-liu/caravel that referenced this pull request Sep 27, 2016

Associate version to entry files (apache#1060)

b75ee66

* Associate version to entry files * Modified path joins for configs * Made changes based on comments

ym97 mentioned this pull request Oct 27, 2016

Explore control panel - Chart control, TimeFilter, GroupBy, Filters (… #1447

Closed

pinkythalli97 mentioned this pull request Oct 29, 2016

Explore control panel - Chart control, TimeFilter, GroupBy, Filters (… #1476

Closed

vera-liu deleted the vliu_add_version_to_entry branch November 1, 2016 19:03

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021

chore(plugin-chart-pivot-table): change thumbnail and name (apache#1060)

6a7209d

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021

chore(plugin-chart-pivot-table): change thumbnail and name (apache#1060)

bed8d31

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021

chore(plugin-chart-pivot-table): change thumbnail and name (apache#1060)

83a002c

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021

chore(plugin-chart-pivot-table): change thumbnail and name (apache#1060)

61d0e4b

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Associate version to entry files #1060

Associate version to entry files #1060

vera-liu commented Sep 2, 2016 •

edited

Loading

vera-liu Sep 2, 2016 •

edited

Loading

mistercrunch Sep 6, 2016

mistercrunch Sep 6, 2016 •

edited

Loading

ascott Sep 6, 2016

mistercrunch commented Sep 6, 2016

ascott Sep 6, 2016

ascott commented Sep 6, 2016 •

edited

Loading

mistercrunch commented Sep 15, 2016

ascott commented Sep 15, 2016

Associate version to entry files #1060

Associate version to entry files #1060

Conversation

vera-liu commented Sep 2, 2016 • edited Loading

vera-liu Sep 2, 2016 • edited Loading

Choose a reason for hiding this comment

mistercrunch Sep 6, 2016

Choose a reason for hiding this comment

mistercrunch Sep 6, 2016 • edited Loading

Choose a reason for hiding this comment

ascott Sep 6, 2016

Choose a reason for hiding this comment

mistercrunch commented Sep 6, 2016

ascott Sep 6, 2016

Choose a reason for hiding this comment

ascott commented Sep 6, 2016 • edited Loading

mistercrunch commented Sep 15, 2016

ascott commented Sep 15, 2016

vera-liu commented Sep 2, 2016 •

edited

Loading

vera-liu Sep 2, 2016 •

edited

Loading

mistercrunch Sep 6, 2016 •

edited

Loading

ascott commented Sep 6, 2016 •

edited

Loading