feat: sort card view by Alphabetical, Recently Modified, and Least Recently Modified #10601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10601 +/- ##
==========================================
+ Coverage 60.10% 64.39% +4.28%
==========================================
Files 775 776 +1
Lines 36528 36559 +31
Branches 3459 3464 +5
==========================================
+ Hits 21955 23541 +1586
+ Misses 14382 12909 -1473
+ Partials 191 109 -82
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
added 2 commits
August 14, 2020 11:52
nytai
approved these changes
Aug 14, 2020
| */ | ||
| import React, { useState } from 'react'; | ||
| import { styled, withTheme, SupersetThemeProps } from '@superset-ui/style'; | ||
| import { PartialThemeConfig, Select } from 'src/components/Select'; |
There was a problem hiding this comment.
we probably could have gotten away with an antd dropdown as we'll only be rendering a few items and don't need search, but this is good for consistency with the filter components.
|
Impacts #8976 |
Ofeknielsen
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Oct 5, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
WIP
ADDITIONAL INFORMATION