Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve documentation for country maps #10621

Merged
merged 1 commit into from
Aug 18, 2020
Merged

improve documentation for country maps #10621

merged 1 commit into from
Aug 18, 2020

Conversation

czue
Copy link
Contributor

@czue czue commented Aug 17, 2020 •
edited
Loading

SUMMARY

The current documentation is both incomplete and incorrect. This fixes it based on actually getting it working.

ADDITIONAL INFORMATION

@czue czue mentioned this pull request Aug 17, 2020
Closed
@czue
Copy link
Contributor Author

czue commented Aug 18, 2020

Thanks for the review @willbarrett - do I have to do anything else to have this merged? Hopefully it will save others much of the trouble that I had to go through.

@willbarrett
Copy link
Member

Nothing more needs doing @czue - we just leave PRs open for a period of time to allow other contributors to weigh in if they are so inclined. I'll merge this now.

@willbarrett willbarrett merged commit 4ee5247 into apache:master Aug 18, 2020
amitmiran137 pushed a commit to amitmiran137/incubator-superset that referenced this pull request Aug 21, 2020
Merge branch 'master' into dynamic-plugin-import
cf13c0a 
* master: (43 commits)
  feat: Getting fancier with Storybook (apache#10647)
  fix: dedup groupby in viz.py while preserving order (apache#10633)
  feat: bump superset-ui for certified tag (apache#10650)
  feat: setup react page with submenu for datasources listview  (apache#10642)
  feat: add certification to metrics (apache#10630)
  feat(viz-plugins): add date formatting to pivot-table (apache#10637)
  fix: controls scroll issue (apache#10644)
  feat: Allow tests files in  /src (plus Label component tests) (apache#10634)
  fix: remove duplicated params and cache_timeout from list_columns; add viz_type to list_columns (apache#10643)
  chore: splitting button stories into separate stories (apache#10631)
  refactor: remove slice level label_colors from dashboard init load (apache#10603)
  feat: card view bulk select (apache#10607)
  style: Label styling/storybook touchups (apache#10627)
  fix: removing unsupported modal sizes (apache#10625)
  feat(datasource): remove deleted columns and update column type on metadata refresh (apache#10619)
  improve documentation for country maps (apache#10621)
  chore: npm audit fix as of 2020-08-15 (apache#10613)
  feat: dataset REST API for distinct values (apache#10595)
  chore: bump react-redux to 5.1.2, whittling console noise (apache#10602)
  fixing console error about bad html attribute (apache#10604)
  ...

# Conflicts:
#	superset-frontend/src/explore/components/ExploreViewContainer.jsx
#	superset-frontend/src/views/App.tsx
#	superset/config.py
@czue
Copy link
Contributor Author

czue commented Aug 25, 2020 •
edited
Loading

I noticed the docs haven't been updated despite this being merged. Is there a separate process for having those built? (I'm trying to document this for a client and it would be nice to have something to link to besides the PR)

@villebro
Copy link
Member

@czue the docs usually reflect the most recent official release. At this time of writing, 0.37.0 is the current version. I can flag this for inclusion in 0.37.1 which is currently being worked on.

villebro pushed a commit that referenced this pull request Sep 16, 2020
@czue @villebro
improve documentation for country maps (#10621)
fc94d74
Ofeknielsen pushed a commit to ofekisr/incubator-superset that referenced this pull request Oct 5, 2020
@czue
improve documentation for country maps (apache#10621)
c74dd73
@czue
Copy link
Contributor Author

czue commented Nov 18, 2020

hey, just wanted to get an update on this - is there a reason the public docs still haven't been updated?

@srinify
Copy link
Contributor

srinify commented Nov 18, 2020

Hi @czue I think this is because updating the Superset docs requires a re-deploy via a manual process https://github.com/apache/incubator-superset/blob/master/docs/README.txt (weirdly, this used to be a .MD file, not sure how it became a .txt file!)

I'll add this to my plate for this week and will circle back to you once I redeploy

auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@czue @auxten
improve documentation for country maps (apache#10621)
0c2b604
@czue czue deleted the fix-country-map-docs branch November 23, 2020 04:47
@czue
Copy link
Contributor Author

czue commented Mar 31, 2021

Your new documentation site looks great! Unfortunately it seems that it is still showing the wrong information here.

Any update on getting the public documentation fixed?

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@czue @villebro
improve documentation for country maps (apache#10621)
1f87e3a
@mistercrunch mistercrunch added 🍒 0.37.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willbarrett willbarrett willbarrett approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v0.37 v0.37.2 🍒 0.37.2 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@czue @willbarrett @villebro @srinify @mistercrunch