Numerous improvements to SQL Lab #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,7 +46,7 @@ class ResultSet extends React.Component { | |||
| > | |||
| <i className="fa fa-line-chart m-l-1" /> Visualize | |||
| </Button> | |||
| <Button bsSize="small"> | |||
| <Button bsSize="small" onClick={this.csv.bind(this)}> | |||
There was a problem hiding this comment.
i think this makes more sense as a simple <a> tag since the csv() is just setting window.location.
const url = `/caravel/csv/${this.props.query.id}`;
<a className="btn btn-sm" href={`/caravel/csv/${url}`}">
...
</a>
|
i think most of this has been reviewed so 👍 🎉 |
|
@ascott nice, I was happy to find that |
mistercrunch
force-pushed
the
sqllab
branch
from
c4849ef to
63c2db8
Compare
This was referenced Jun 2, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
added indonesia map. geojson file was created via jupyter notebook script Co-authored-by: macbook <lim@MacBook-Pro.local>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
added indonesia map. geojson file was created via jupyter notebook script Co-authored-by: macbook <lim@MacBook-Pro.local>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
added indonesia map. geojson file was created via jupyter notebook script Co-authored-by: macbook <lim@MacBook-Pro.local>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
added indonesia map. geojson file was created via jupyter notebook script Co-authored-by: macbook <lim@MacBook-Pro.local>
mistercrunch
added
the
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.