Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed disabled globally rule: old-ne-operator #10915

Merged
merged 1 commit into from
Sep 17, 2020
Merged

fix: removed disabled globally rule: old-ne-operator #10915

merged 1 commit into from
Sep 17, 2020

Conversation

kkucharc
Copy link
Contributor

@kkucharc kkucharc commented Sep 16, 2020 •
edited
Loading

SUMMARY

Pylint rule old-ne-operator doesn't need to be disabled anymore. An old operator is <> which doesn't appear in code. Removing it from .pylintrc doesn't impact checks.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@kkucharc kkucharc changed the title removed disabled globally rule: old-ne-operator fix: removed disabled globally rule: old-ne-operator Sep 16, 2020
@kkucharc
Copy link
Contributor Author

@willbarrett would you take a look?

@willbarrett willbarrett merged commit 8735a14 into apache:master Sep 17, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@kkucharc @auxten
Removed global pylintrc rule: old-ne-operator. Which is not applicabl…
7c941a2 
…e in code anymore. (apache#10915)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willbarrett willbarrett willbarrett approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkucharc @willbarrett @mistercrunch