fix: Enable ESLint rule default-props-match-prop-types #11058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@graceguo-supercat It fixes a bug reported by you, can you please take a look? |
Codecov Report
@@ Coverage Diff @@
## master #11058 +/- ##
==========================================
- Coverage 65.79% 60.99% -4.81%
==========================================
Files 816 816
Lines 38422 38402 -20
Branches 3621 3621
==========================================
- Hits 25280 23422 -1858
- Misses 13034 14794 +1760
- Partials 108 186 +78
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rusackas
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
LGTM, but I'd love to get a thumbs up from @graceguo-supercat before merging this one. Thanks for the test addition!
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* Re-enable ESLint rule default-props-match-props-types * Add cypress test for switching tabs * fix * Typo fix * Test fix
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes a bug introduced in #10868 (reverted by #11050)
Cypress test was added to make sure that the tabs switch correctly.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION