style(sqllab): make database errors more clear and render as monospace #11075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
reviewed
Sep 28, 2020
|
@rusackas, addressed your comment! |
etr2460
reviewed
Sep 29, 2020
There was a problem hiding this comment.
Instead of passing through a prop to render the subtitle as monospace, why not wrap the subtitle in the ResultSet component and then pass it through? it's defined as a ReactNode in ErrorAlert, so you could change the typing in ErrorMessageWithStackTrace and avoid passing down the other prop. It would also help keep these error components more generic
mistercrunch
force-pushed
the
monospace_database_error
branch
from
1fcde95 to
70d71d7
Compare
|
@etr2460 I used your approach, thanks for the suggestion! |
In SQL Lab, when a database error message is returned, generally because of a user error in the SQL, it's identified as an "Unexpected Error" and some of the text formatting of the error message (\n, spaces, tabs, ...) are lost as they are rendered in html. This PR identifies the error as a "Database Error", and renders like more like a <pre>, using a monospace font.
mistercrunch
force-pushed
the
monospace_database_error
branch
from
70d71d7 to
bd64825
Compare
Codecov Report
@@ Coverage Diff @@
## master #11075 +/- ##
==========================================
- Coverage 65.73% 65.72% -0.01%
==========================================
Files 819 819
Lines 38865 38868 +3
Branches 3669 3670 +1
==========================================
Hits 25546 25546
- Misses 13209 13212 +3
Partials 110 110
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
etr2460
approved these changes
Oct 1, 2020
superset-frontend/src/components/ErrorMessage/ErrorMessageWithStackTrace.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/components/ErrorMessage/ErrorMessageWithStackTrace.tsx
Show resolved
Hide resolved
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
apache#11075) * style(sqllab): make database errors more clear and render as monospace In SQL Lab, when a database error message is returned, generally because of a user error in the SQL, it's identified as an "Unexpected Error" and some of the text formatting of the error message (\n, spaces, tabs, ...) are lost as they are rendered in html. This PR identifies the error as a "Database Error", and renders like more like a <pre>, using a monospace font. * fix the build * addressing comments * addressed comments * lint + removing cruft * addressing comments
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SQL Lab, when a database error message is returned, generally because
of a user error in the SQL, it's identified as an "Unexpected Error" and
some of the text formatting of the error message (\n, spaces, tabs, ...)
are lost as they are rendered in html.
This PR identifies the error as a "Database Error", and renders like
more like a