Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove SIP_34_SAVED_QUERIES_UI feature flag #11175

Merged
merged 2 commits into from
Oct 6, 2020

Conversation

lilykuang
Copy link
Member

@lilykuang lilykuang commented Oct 6, 2020

SUMMARY

SIP_34_SAVED_QUERIES_UI was added to hide saved queries CRUD view UI while developing. The feature is ready to use.

  • removed SIP_34_SAVED_QUERIES_UI flag
  • only use ENABLE_REACT_CRUD_VIEWS flag

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@nytai nytai changed the title feat: removed SIP_34_SAVED_QUERIES_UI flag chore: remove SIP_34_SAVED_QUERIES_UI feature flag Oct 6, 2020
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Oct 6, 2020
@codecov-io
Copy link

codecov-io commented Oct 6, 2020

Codecov Report

Merging #11175 into master will decrease coverage by 5.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11175      +/-   ##
==========================================
- Coverage   61.67%   56.08%   -5.60%     
==========================================
  Files         828      403     -425     
  Lines       39117    13370   -25747     
  Branches     3687     3424     -263     
==========================================
- Hits        24126     7498   -16628     
+ Misses      14810     5688    -9122     
- Partials      181      184       +3     
Flag Coverage Δ
#cypress 56.08% <ø> (?)
#javascript ?
#python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/featureFlags.ts 100.00% <ø> (+12.50%) ⬆️
superset-frontend/src/views/CRUD/data/common.ts 100.00% <ø> (ø)
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...rc/dashboard/util/getLayoutComponentFromChartId.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
superset-frontend/src/common/components/Modal.tsx 6.66% <0.00%> (-93.34%) ⬇️
.../src/dashboard/components/FilterIndicatorGroup.jsx 11.76% <0.00%> (-88.24%) ⬇️
...c/explore/components/controls/withVerification.jsx 9.09% <0.00%> (-87.88%) ⬇️
... and 720 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8a5dec...53c6bc3. Read the comment docs.

@lilykuang lilykuang force-pushed the lily/remove-SIP_34_SAVED_QUERIES_UI branch from a3358eb to 53c6bc3 Compare October 6, 2020 21:25
@nytai nytai merged commit 2eb400a into apache:master Oct 6, 2020
@nytai nytai deleted the lily/remove-SIP_34_SAVED_QUERIES_UI branch October 6, 2020 22:13
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants