feat: CSS Templates List #11189
Merged
feat: CSS Templates List #11189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11189 +/- ##
==========================================
- Coverage 65.61% 61.53% -4.09%
==========================================
Files 828 829 +1
Lines 39148 39194 +46
Branches 3589 3596 +7
==========================================
- Hits 25687 24117 -1570
- Misses 13350 14896 +1546
- Partials 111 181 +70
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
riahk
force-pushed
the
moriah/css-templates-list
branch
from
2debb94 to
1085dcb
Compare
riahk
force-pushed
the
moriah/css-templates-list
branch
from
1085dcb to
420251d
Compare
nytai
approved these changes
Oct 8, 2020
| import waitForComponentToPaint from 'spec/helpers/waitForComponentToPaint'; | ||
| // import { act } from 'react-dom/test-utils'; | ||
|
|
||
| // store needed for withToasts(DatabaseList) |
| import CssTemplatesList from 'src/views/CRUD/csstemplates/CssTemplatesList'; | ||
| import SubMenu from 'src/components/Menu/SubMenu'; | ||
| import ListView from 'src/components/ListView'; | ||
| // import Filters from 'src/components/ListView/Filters'; |
| import SubMenu from 'src/components/Menu/SubMenu'; | ||
| import { IconName } from 'src/components/Icon'; | ||
| import ActionsBar, { ActionProps } from 'src/components/ListView/ActionsBar'; | ||
| // import ListView, { Filters } from 'src/components/ListView'; |
| { | ||
| Cell: ({ row: { original } }: any) => { | ||
| const handleEdit = () => {}; // handleDatabaseEdit(original); | ||
| const handleDelete = () => {}; // openDatabaseDeleteModal(original); |
There was a problem hiding this comment.
nit: incorrectly named and commented out code
| count={templatesCount} | ||
| data={templates} | ||
| fetchData={fetchData} | ||
| // filters={filters} |
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ENABLE_REACT_CRUD_VIEWSandSIP_34_CSS_TEMPLATES_UICssTemplatesListBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION