Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add IBM Kubernetes guide #11197

Closed
wants to merge 4 commits into from
Closed

docs: Add IBM Kubernetes guide #11197

wants to merge 4 commits into from

Conversation

aklin
Copy link
Contributor

@aklin aklin commented Oct 7, 2020

SUMMARY

Add installation guide for Kubernets on IBM Cluster using Helm.

Installation is non-trivial and this is bound to save a lot of hours for people.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

  • Document renders correctly, without console messages
  • GH action "Frontend" is green

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Sorry, something went wrong.

@aklin aklin changed the title Add IBM Kubernetes guide docs: Add IBM Kubernetes guide Oct 7, 2020
@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #11197 into master will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11197      +/-   ##
==========================================
+ Coverage   65.43%   65.67%   +0.24%     
==========================================
  Files         829      828       -1     
  Lines       39200    39162      -38     
  Branches     3693     3694       +1     
==========================================
+ Hits        25649    25720      +71     
+ Misses      13444    13332     -112     
- Partials      107      110       +3     
Flag Coverage Δ
#cypress 56.10% <ø> (+0.23%) ⬆️
#javascript 62.30% <ø> (-0.03%) ⬇️
#python 61.01% <ø> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/explore/components/controls/withVerification.jsx
...re/components/controls/TimeSeriesColumnControl.jsx
...uperset-frontend/src/dashboard/util/dnd-reorder.js
superset-frontend/src/setup/setupFormatters.js
...perset-frontend/src/addSlice/AddSliceContainer.tsx
...nd/src/dashboard/components/gridComponents/Row.jsx
...d/src/dashboard/util/updateComponentParentsList.js
...nd/src/messageToasts/components/ToastPresenter.tsx
...board/components/gridComponents/new/NewDivider.jsx
...plore/components/controls/FixedOrMetricControl.jsx
... and 866 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9785667...99dc3c5. Read the comment docs.

@mistercrunch
Copy link
Member

Grateful for the contribution, but this is going to be impossible for the core team to maintain / keep up to date.

I suggest this would be better hosted somewhere else and we can link to it.

Ive been caught in dealing with issues and PRs on community contributed docs or extensions I have zero context on in the past and that's not great. It gets stale and creates confusion in the community and with maintainers.

@aklin
Copy link
Contributor Author

aklin commented Oct 9, 2020

Hello @mistercrunch, thanks for looking into this and explaining why accepting it would be a problem. It makes sense and frankly I didn't think of it when submitting the PR.

The guide is also hosted on my personal blog on this URL if linking as an external resource would work for you. I would be happy to create that PR as well, if your time is limited, but I would need some guidance to make sure it ends up in the right place.

@mistercrunch
Copy link
Member

How about under here? https://github.com/apache/incubator-superset/blob/master/docs/src/pages/resources.tsx#L62

It'll show up here: https://superset.apache.org/resources/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants