Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace usages of reactable in ChangeDatasourceModal #11241

Merged
merged 3 commits into from
Oct 20, 2020
Merged

refactor: Replace usages of reactable in ChangeDatasourceModal #11241

merged 3 commits into from
Oct 20, 2020

Conversation

kgabryje
Copy link
Member

SUMMARY

This PR refactors ChangeDatasourceModal to use TableView, based on react-table library. The goal was to get rid of reactable.
This PR replaces #10982.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje kgabryje marked this pull request as draft October 12, 2020 15:30
@codecov-io
Copy link

codecov-io commented Oct 12, 2020 •
edited
Loading

Codecov Report

Merging #11241 into master will decrease coverage by 5.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11241      +/-   ##
==========================================
- Coverage   65.62%   59.83%   -5.79%     
==========================================
  Files         834      393     -441     
  Lines       39559    24834   -14725     
  Branches     3610        0    -3610     
==========================================
- Hits        25959    14860   -11099     
+ Misses      13492     9974    -3518     
+ Partials      108        0     -108
Flag Coverage Δ
#cypress ?
#javascript ?
#python 59.83% <ø> (-0.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 53.90% <0.00%> (-30.08%) ⬇️
superset/db_engine_specs/mysql.py 79.59% <0.00%> (-12.25%) ⬇️
superset/db_engine_specs/sqlite.py 65.62% <0.00%> (-9.38%) ⬇️
superset/databases/commands/create.py 82.97% <0.00%> (-8.52%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/connectors/sqla/models.py 83.53% <0.00%> (-6.21%) ⬇️
superset/databases/api.py 85.10% <0.00%> (-4.26%) ⬇️
superset/utils/celery.py 82.14% <0.00%> (-3.58%) ⬇️
superset/models/core.py 85.75% <0.00%> (-3.36%) ⬇️
... and 451 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc03549...787018d. Read the comment docs.

@kgabryje kgabryje force-pushed the react-table/changedatasourcemodal branch from 914208f to 787018d Compare October 15, 2020 12:37
@pull-request-size pull-request-size bot added size/M and removed size/L labels Oct 15, 2020
@kgabryje kgabryje changed the title refactor: Replace usages of reactable in ChangeDatasourceModal (depends on #11217) refactor: Replace usages of reactable in ChangeDatasourceModal Oct 15, 2020
@kgabryje kgabryje marked this pull request as ready for review October 15, 2020 12:38
rusackas
rusackas approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one potential NIT to consider before merging.

@rusackas rusackas merged commit 9266f0a into apache:master Oct 20, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@kgabryje @auxten
refactor: Replace usages of reactable in ChangeDatasourceModal (apach…
c3e9e6f 
…e#11241)

* Refactor ChangeDatasourceModal to use react-table

* Fix import

* Moved columns declaration out of component scope
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kgabryje @codecov-io @rusackas @mistercrunch