Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactored api_tests in charts #11249

Merged

Conversation

kkucharc
Copy link
Contributor

Refactored api_tests.py in charts:

  • splitted big test into 3 test cases
  • added fixture that prepares charts for splitted test cases
  • retrieving energy table id for which charts are created (instead of defined "magic number").

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

…ests cases. Added table id based on database id
@codecov-io
Copy link

codecov-io commented Oct 13, 2020

Codecov Report

Merging #11249 into master will decrease coverage by 4.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11249      +/-   ##
==========================================
- Coverage   65.60%   61.47%   -4.13%     
==========================================
  Files         832      832              
  Lines       39400    39397       -3     
  Branches     3593     3593              
==========================================
- Hits        25849    24221    -1628     
- Misses      13442    14995    +1553     
- Partials      109      181      +72     
Flag Coverage Δ
#cypress ?
#javascript 62.62% <ø> (ø)
#python 60.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupFormatters.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupPluginsExtra.js 0.00% <0.00%> (-100.00%) ⬇️
... and 165 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88af85a...80bc5fd. Read the comment docs.

@kkucharc kkucharc requested a review from willbarrett October 13, 2020 12:03
@kkucharc kkucharc added the test label Oct 13, 2020
@kkucharc kkucharc changed the title test: refactored api_tests in charts test: refactored api_tests in charts [WIP Oct 14, 2020
@kkucharc kkucharc changed the title test: refactored api_tests in charts [WIP test: refactored api_tests in charts [WIP] Oct 14, 2020
@willbarrett willbarrett merged commit 9caf875 into apache:master Oct 14, 2020
@kkucharc kkucharc changed the title test: refactored api_tests in charts [WIP] test: refactored api_tests in charts Oct 27, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants